From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21083: 24.5; Infinite loop in called-interactively-p Date: Tue, 21 Jul 2015 19:10:07 -0400 Message-ID: References: <87fv4mrur4.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1437520341 27166 80.91.229.3 (21 Jul 2015 23:12:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jul 2015 23:12:21 +0000 (UTC) Cc: 21083-done@debbugs.gnu.org To: Dmitri Paduchikh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 22 01:12:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZHggp-0006as-B7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jul 2015 01:11:11 +0200 Original-Received: from localhost ([::1]:33326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHggo-0002H0-BI for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jul 2015 19:11:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHggl-0002Gv-0P for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2015 19:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHggh-0004nK-0m for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2015 19:11:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHggg-0004nG-Tl for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2015 19:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZHggg-0008Hw-J6 for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2015 19:11:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jul 2015 23:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 21083@debbugs.gnu.org, monnier@iro.umontreal.ca, dpaduchikh@gmail.com Original-Received: via spool by 21083-done@debbugs.gnu.org id=D21083.143752021531798 (code D ref 21083); Tue, 21 Jul 2015 23:11:02 +0000 Original-Received: (at 21083-done) by debbugs.gnu.org; 21 Jul 2015 23:10:15 +0000 Original-Received: from localhost ([127.0.0.1]:55775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZHgfu-0008Gl-Vl for submit@debbugs.gnu.org; Tue, 21 Jul 2015 19:10:15 -0400 Original-Received: from smtp-pri-02-1.vtxnet.net ([212.147.62.146]:58697 helo=smtp-pri-02.vtxnet.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZHgfs-0008GS-Et for 21083-done@debbugs.gnu.org; Tue, 21 Jul 2015 19:10:13 -0400 Original-Received: from localhost (unknown [127.0.0.1]) by smtp-pri-02.vtxnet.net (VTX Services SA) with ESMTP id 569C637DD57; Wed, 22 Jul 2015 01:10:11 +0200 (CEST) Original-Received: from smtp-pri-02.vtxnet.net ([212.147.62.146]) by localhost (smtp-pri-02.vtxnet.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oIgBpss2cmaC; Wed, 22 Jul 2015 01:10:08 +0200 (CEST) Original-Received: from fmsmemgm.homelinux.net (dyn.83-228-180-068.dsl.vtx.ch [83.228.180.68]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-pri-02.vtxnet.net (VTX Services SA) with ESMTP id 3429E37DD56; Wed, 22 Jul 2015 01:10:08 +0200 (CEST) Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 63BDDAF16E; Tue, 21 Jul 2015 19:10:07 -0400 (EDT) In-Reply-To: <87fv4mrur4.fsf@gmail.com> (Dmitri Paduchikh's message of "Sat, 18 Jul 2015 08:48:31 +0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105064 Archived-At: > I have prepared a simple example to reproduce the problem. In the > attachment is a small elisp file testfile.el. Save it and execute: Thanks, that made it easy. I installed the patch below which should fix the inf-loop. Stefan diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el index a6db5e9..5a59a98 100644 --- a/lisp/emacs-lisp/nadvice.el +++ b/lisp/emacs-lisp/nadvice.el @@ -522,8 +522,9 @@ of the piece of advice." (while (progn (funcall get-next-frame) - (not (and (eq (nth 1 frame2) 'apply) - (eq (nth 3 frame2) inneradvice))))) + (and frame2 + (not (and (eq (nth 1 frame2) 'apply) + (eq (nth 3 frame2) inneradvice)))))) (funcall get-next-frame) (funcall get-next-frame)))) (- i origi 1))))