From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitri Paduchikh <dpaduchikh@gmail.com>
Cc: 21083-done@debbugs.gnu.org
Subject: bug#21083: 24.5; Infinite loop in called-interactively-p
Date: Tue, 21 Jul 2015 19:10:07 -0400 [thread overview]
Message-ID: <jwvpp3lkt0f.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87fv4mrur4.fsf@gmail.com> (Dmitri Paduchikh's message of "Sat, 18 Jul 2015 08:48:31 +0500")
> I have prepared a simple example to reproduce the problem. In the
> attachment is a small elisp file testfile.el. Save it and execute:
Thanks, that made it easy.
I installed the patch below which should fix the inf-loop.
Stefan
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index a6db5e9..5a59a98 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -522,8 +522,9 @@ of the piece of advice."
(while
(progn
(funcall get-next-frame)
- (not (and (eq (nth 1 frame2) 'apply)
- (eq (nth 3 frame2) inneradvice)))))
+ (and frame2
+ (not (and (eq (nth 1 frame2) 'apply)
+ (eq (nth 3 frame2) inneradvice))))))
(funcall get-next-frame)
(funcall get-next-frame))))
(- i origi 1))))
prev parent reply other threads:[~2015-07-21 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 3:48 bug#21083: 24.5; Infinite loop in called-interactively-p Dmitri Paduchikh
2015-07-21 23:10 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpp3lkt0f.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=21083-done@debbugs.gnu.org \
--cc=dpaduchikh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.