From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: David Reitter <david.reitter@gmail.com>
Subject: Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system
Date: Fri, 10 Jun 2016 11:54:59 -0400 [thread overview]
Message-ID: <jwvporp6pk3.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20160610080445.5113D220143@vcs.savannah.gnu.org> (David Reitter's message of "Fri, 10 Jun 2016 08:04:45 +0000 (UTC)")
> ;; Pre-write conversion for `utf-8-hfs'.
> (defun ucs-normalize-hfs-nfd-pre-write-conversion (from to)
> - (let ((old-buf (current-buffer)))
> - (set-buffer (generate-new-buffer " *temp*"))
> - (if (stringp from)
> - (insert from)
> - (insert-buffer-substring old-buf from to))
> - (ucs-normalize-HFS-NFD-region (point-min) (point-max))
> - nil))
> + (ucs-normalize-HFS-NFD-region (point-min) (point-max)))
Could you add a comment explaining why it's OK to ignore `from` and `to`
here (as well as rename those args to `_from` and `_to` to make it
clear to the byte-compiler that we purposefully ignore them)?
Stefan
next parent reply other threads:[~2016-06-10 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160610080445.616.81209@vcs.savannah.gnu.org>
[not found] ` <20160610080445.5113D220143@vcs.savannah.gnu.org>
2016-06-10 15:54 ` Stefan Monnier [this message]
2016-06-13 9:12 ` [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system David Reitter
2016-06-13 12:22 ` Stefan Monnier
2016-06-13 14:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvporp6pk3.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.