Why does advice-member-p accept only a SYMBOL

Why does advice-member-p accept only a SYMBOL

[Michael Heerdegen]

Hi,

Why is advice-member-p limited to search only SYMBOL definitions
(i.e. symbol-functions)?  Wouldn't it be useful to have a predicate that
would accept a PLACE as in `add-function'?  AFAIK there is no such thing
in nadvice.el.


Thanks,

Michael.

Re: Why does advice-member-p accept only a SYMBOL

[Stefan Monnier]

> Why is advice-member-p limited to search only SYMBOL definitions
> (i.e. symbol-functions)?  Wouldn't it be useful to have a predicate that
> would accept a PLACE as in `add-function'?  AFAIK there is no such thing
> in nadvice.el.

advice-function-member-p ?


        Stefan

Re: Why does advice-member-p accept only a SYMBOL

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> advice-function-member-p ?

But that doesn't accept something like (var VARIABLE) or (local
VARIABLE) etc. as in `add-function', right?

Re: Why does advice-member-p accept only a SYMBOL

[Stefan Monnier]

>> advice-function-member-p ?
> But that doesn't accept something like (var VARIABLE) or (local
> VARIABLE) etc. as in `add-function', right?

Not sure.  But if so, it's a bug.


        Stefan

Re: Why does advice-member-p accept only a SYMBOL

[Stefan Monnier]

>> advice-function-member-p ?
> But that doesn't accept something like (var VARIABLE) or (local
> VARIABLE) etc. as in `add-function', right?

Oh, yes, sorry, I double checked and you're right.  It works for most
places but not for the special ad-hoc places of add-function (aka `var'
and `local').


        Stefan