From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Unbalanced change hooks (part 2) [Documentation fix still remaining] Date: Wed, 10 Aug 2016 10:56:59 -0400 Message-ID: References: <83fuqnm6og.fsf@gnu.org> <83eg67m3aq.fsf@gnu.org> <20160808143614.GA7208@acm.fritz.box> <83mvkni7xf.fsf@gnu.org> <20160808165449.GB7208@acm.fritz.box> <83d1lji3ih.fsf@gnu.org> <20160808184223.GC7208@acm.fritz.box> <838tw7hyk2.fsf@gnu.org> <20160808195459.GD7208@acm.fritz.box> <83tweugeu9.fsf@gnu.org> <20160809163814.GD4893@acm.fritz.box> <83inv9hkjd.fsf@gnu.org> <83h9ashfgx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1470841062 14321 195.159.176.226 (10 Aug 2016 14:57:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 Aug 2016 14:57:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 10 16:57:38 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXUwr-0003Z8-0R for ged-emacs-devel@m.gmane.org; Wed, 10 Aug 2016 16:57:37 +0200 Original-Received: from localhost ([::1]:42112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXUwn-0003ZP-RP for ged-emacs-devel@m.gmane.org; Wed, 10 Aug 2016 10:57:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXUwb-0003WG-Ec for emacs-devel@gnu.org; Wed, 10 Aug 2016 10:57:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXUwW-0007U2-9k for emacs-devel@gnu.org; Wed, 10 Aug 2016 10:57:20 -0400 Original-Received: from [195.159.176.226] (port=35526 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXUwW-0007Rz-2H for emacs-devel@gnu.org; Wed, 10 Aug 2016 10:57:16 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bXUwP-0002hc-7C for emacs-devel@gnu.org; Wed, 10 Aug 2016 16:57:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:D9wosinAG34+2VQCEZdGp/pP15Y= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206540 Archived-At: > AFAICT, this is what happens, indeed, Then the old text was right: it's called before ANY modification. > except that the call to before-change-functions in some cases does not > precede the first modification of the series. IOW, by the time the > hook is called, some modifications were already done. Sounds like a bug. In any case, my point is that the doc should still say "before any modification" because that's really what the code *should* do. We could add a blurb in the doc saying that the before and after hooks may not be properly paired (neither in number of calls nor in the specific value of BEG/END), but we should still claim that they're both called for any and all modifications (modulo inhibit-modification-hooks, obviously). Stefan