From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 50548fd: cl-fill: Rename arguments to cl-seq and cl-item Date: Tue, 16 Aug 2016 11:04:32 -0400 Message-ID: References: <20160813042949.31299.44303@vcs.savannah.gnu.org> <20160813042950.2B1CB2201C2@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471359934 11434 195.159.176.226 (16 Aug 2016 15:05:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Aug 2016 15:05:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Tino Calancha , emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 16 17:05:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZfvj-0002XV-5b for ged-emacs-devel@m.gmane.org; Tue, 16 Aug 2016 17:05:27 +0200 Original-Received: from localhost ([::1]:42658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZfvg-0005wk-CG for ged-emacs-devel@m.gmane.org; Tue, 16 Aug 2016 11:05:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZfv7-0005wb-In for emacs-devel@gnu.org; Tue, 16 Aug 2016 11:04:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZfv2-0005M2-J6 for emacs-devel@gnu.org; Tue, 16 Aug 2016 11:04:48 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:40059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZfv2-0005Lp-Em for emacs-devel@gnu.org; Tue, 16 Aug 2016 11:04:44 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u7GF57LA003767; Tue, 16 Aug 2016 11:05:09 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id EEC3DAE0E7; Tue, 16 Aug 2016 11:04:32 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Tue, 16 Aug 2016 22:00:07 +0800") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5768=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5768> : inlines <5102> : streams <1685086> : uri <2268124> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206614 Archived-At: > Apparently the functions surrounding cl-fill use cl- prefix. so the > change appear to be more cosmetic than technical. Indeed. But since the "cl-" prefix has to be used for global (aka dynamically scoped) variables, it's good practice to *not* use it for lexically scoped variables. IOW, I'm all for such cosmetic changes that harmonize the code, but we should do that by removing (rather than adding) the "cl-" prefix where it's not needed. Stefan