Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972)

Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972)

[Stefan Monnier]

> -		`(truncate-string-to-width
> -		  ,strvar strlen nil nil
> -		  ,ellipsis))
> +		`(concat
> +		  (truncate-string-to-width
> +                   ,strvar (- strlen (string-width ,ellipsis)) nil ?.)
> +                  ,ellipsis))

Hmm... why was this needed?


        Stefan "maybe it should be fixed in truncate-string-to-width instead"

Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972)

[Mark Oteiza]

On 22/11/16 at 08:17am, Stefan Monnier wrote:
> > -		`(truncate-string-to-width
> > -		  ,strvar strlen nil nil
> > -		  ,ellipsis))
> > +		`(concat
> > +		  (truncate-string-to-width
> > +                   ,strvar (- strlen (string-width ,ellipsis)) nil ?.)
> > +                  ,ellipsis))
> 
> Hmm... why was this needed?
> 
> 
>         Stefan "maybe it should be fixed in truncate-string-to-width instead"

Your guess would probably be better than mine.  Perhaps I needed to
/add/ the length of the ellipsis to strlen in the removed code?  I was
quite ready to rip my hair out trying to make sense of all that ibuffer
machinery.  Horribly untestable the way it's written as well.