From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972) Date: Tue, 22 Nov 2016 08:17:53 -0500 Message-ID: References: <20161122074808.5832.60015@vcs.savannah.gnu.org> <20161122074808.974112201C5@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1479920748 26454 195.159.176.226 (23 Nov 2016 17:05:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 Nov 2016 17:05:48 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 23 18:05:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9azO-0006JA-SG for ged-emacs-devel@m.gmane.org; Wed, 23 Nov 2016 18:05:42 +0100 Original-Received: from localhost ([::1]:35024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9azS-0001JE-A5 for ged-emacs-devel@m.gmane.org; Wed, 23 Nov 2016 12:05:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9aob-0001ap-8a for emacs-devel@gnu.org; Wed, 23 Nov 2016 11:54:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9aoY-0000YX-PP for emacs-devel@gnu.org; Wed, 23 Nov 2016 11:54:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19344) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9aoY-0000UI-BK for emacs-devel@gnu.org; Wed, 23 Nov 2016 11:54:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DfBQALW9BX/0ahSC1dGwEBAQMBAQFDgmoBAQEBAR6ETbdJhhYEAgKBaT0QAQIBAQEBAQEBXieEYgEBBFYjEAs0BwsUGA2JAbxVAQEBBwIBJIp9hQyFEAWPHYo8kRUBh3eGCxSQNzUfgxuBUx6GCgEBAQ X-IPAS-Result: A0DfBQALW9BX/0ahSC1dGwEBAQMBAQFDgmoBAQEBAR6ETbdJhhYEAgKBaT0QAQIBAQEBAQEBXieEYgEBBFYjEAs0BwsUGA2JAbxVAQEBBwIBJIp9hQyFEAWPHYo8kRUBh3eGCxSQNzUfgxuBUx6GCgEBAQ X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="280207612" Original-Received: from 45-72-161-70.cpe.teksavvy.com (HELO pastel.home) ([45.72.161.70]) by smtp.teksavvy.com with ESMTP; 23 Nov 2016 11:54:27 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D68F264EC4; Tue, 22 Nov 2016 08:17:53 -0500 (EST) In-Reply-To: <20161122074808.974112201C5@vcs.savannah.gnu.org> (Mark Oteiza's message of "Tue, 22 Nov 2016 07:48:08 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209570 Archived-At: > - `(truncate-string-to-width > - ,strvar strlen nil nil > - ,ellipsis)) > + `(concat > + (truncate-string-to-width > + ,strvar (- strlen (string-width ,ellipsis)) nil ?.) > + ,ellipsis)) Hmm... why was this needed? Stefan "maybe it should be fixed in truncate-string-to-width instead"