From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under GC_CHECK_MARKED_OBJECTS Date: Wed, 21 Dec 2016 17:52:47 -0500 Message-ID: References: <20161221201813.3130.28327@vcs.savannah.gnu.org> <20161221201813.A13CA2201BA@vcs.savannah.gnu.org> <83oa0510dj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482360793 26612 195.159.176.226 (21 Dec 2016 22:53:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2016 22:53:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 21 23:53:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJpkn-0005Ax-TE for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2016 23:52:58 +0100 Original-Received: from localhost ([::1]:59482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJpks-0001t7-GR for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2016 17:53:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJpkl-0001sL-G0 for emacs-devel@gnu.org; Wed, 21 Dec 2016 17:52:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJpkk-0005xI-RQ for emacs-devel@gnu.org; Wed, 21 Dec 2016 17:52:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:28470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cJpkg-0005wF-CW; Wed, 21 Dec 2016 17:52:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0B0FwAu3EVY/+J3oWxdGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUhHiXCg4YAZALhEuCCIYcBAICghFAFAECAQEBAQEBAWIoQhIBhBQBBAFWIxALNBIUGA0kiHoIrRSLRAELASSLGYopAQSPfIRrhX+Sc4gngT+Ee0mQBYFBHzd4Ew6FcyCGMYJ8AQEB X-IPAS-Result: A0B0FwAu3EVY/+J3oWxdGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUhHiXCg4YAZALhEuCCIYcBAICghFAFAECAQEBAQEBAWIoQhIBhBQBBAFWIxALNBIUGA0kiHoIrRSLRAELASSLGYopAQSPfIRrhX+Sc4gngT+Ee0mQBYFBHzd4Ew6FcyCGMYJ8AQEB X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="283477917" Original-Received: from 108-161-119-226.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([108.161.119.226]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 21 Dec 2016 17:52:48 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C6ADDAE0E1; Wed, 21 Dec 2016 17:52:47 -0500 (EST) In-Reply-To: <83oa0510dj.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 21 Dec 2016 22:40:56 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210720 Archived-At: >> If they're removed from all_threads when the thread terminates, then >> there can still be references to the thread object stored elsewhere in >> the heap. > They are all unlinked in run_thread, when the thread exits, AFAICT. > Or maybe I don't understand what you mean by "references". AFAIK `make-thread` returns a thread object, which you can store anywhere you like. So even if you remove the thread object from all_threads, it may still be referenced from all kinds of other place. Stefan