From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26.0.50 (Git@head) Nested defsubst fails Date: Thu, 23 Feb 2017 23:12:32 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487909616 17290 195.159.176.226 (24 Feb 2017 04:13:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Feb 2017 04:13:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 24 05:13:24 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ch7Fw-00031X-AY for ged-emacs-devel@m.gmane.org; Fri, 24 Feb 2017 05:13:20 +0100 Original-Received: from localhost ([::1]:34536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ch7G2-00086z-7k for ged-emacs-devel@m.gmane.org; Thu, 23 Feb 2017 23:13:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ch7FP-00080r-Mm for emacs-devel@gnu.org; Thu, 23 Feb 2017 23:12:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ch7FK-0002ij-PK for emacs-devel@gnu.org; Thu, 23 Feb 2017 23:12:47 -0500 Original-Received: from [195.159.176.226] (port=33023 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ch7FK-0002iP-JH for emacs-devel@gnu.org; Thu, 23 Feb 2017 23:12:42 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1ch7FB-00073Z-KW for emacs-devel@gnu.org; Fri, 24 Feb 2017 05:12:33 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:b9NbNckVAtxyJDrYAhJOQ7uCnww= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212562 Archived-At: > According to that file, defsubst and cl-defsubst appear to have > different issues with each --- though defsubst at least fo rmy use-case > has worked well for 20+ years. `defsubst` is supposed to work reliably (with the caveat that it doesn't support recursion, which would result in infinite-inlining) and be very easy to use. `cl-defsubst` can result in slightly more efficient code, but has various quirks. `define-inline` is designed to be reliable and give good performance: it should result in code that's at least as efficient as that of `cl-defubst`. But it requires more effort on the part of the programmer (it asks the programmer to write a kind of restricted macro). I think `cl-defsubst` should be deprecated: if performance really matters, `define-inline` is a better choice anyway and it's not that hard to use. Maybe the same could be said of `defsubst` but I haven't thought enough about it to be sure. Stefan