From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility with pre-existing struct instances.
Date: Wed, 29 Mar 2017 08:26:10 -0400 [thread overview]
Message-ID: <jwvpoh01dfo.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 86y3voh8wf.fsf@molnjunk.nocrew.org
> There's also a lingering FIXME that you added:
>
> (cl-defstruct (eieio--object
> - (:type vector) ;We manage our own tagging system.
> + (:type vector) ;; FIXME! ;We manage our own tagging system.
> (:constructor nil)
>
> As far as I can see, the struct isn't used directly.
Indeed, which is why it works despite the inconsistency.
> These definitions are derived from it: eieio--object-class-tag, and
> eieio--object-num-slot. The first just aref slot 0, and the second is 1.
That's right. I put a FIXME because this inconsistency is ugly.
I'm not completely sure how best to fix it, tho. Maybe just define
those two accessors by hand.
Stefan
next prev parent reply other threads:[~2017-03-29 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170328192614.13038.29393@vcs0.savannah.gnu.org>
[not found] ` <20170328192617.32EF32017F@vcs0.savannah.gnu.org>
2017-03-28 20:47 ` [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility with pre-existing struct instances Stefan Monnier
2017-03-29 6:52 ` Lars Brinkhoff
2017-03-29 12:26 ` Stefan Monnier [this message]
2017-03-29 17:18 ` Lars Brinkhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpoh01dfo.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.