* Re: master a855473 2/2: Use user-error for customize's "invalid face" error
[not found] ` <20170414001730.9292C220BE@vcs0.savannah.gnu.org>
@ 2017-04-14 0:57 ` Glenn Morris
2017-04-14 14:11 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2017-04-14 0:57 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Hi Stefan,
After committing the following I noticed that you left it out of your
71873e2. Do you remember why?
Glenn Morris wrote:
> branch: master
> commit a855473b7079b467ac01dbcee89cb57b3599fdac
>
> Use user-error for customize's "invalid face" error
>
> * lisp/cus-edit.el (customize-face): Use user-error.
> (debug-ignored-errors): No more need to add "Invalid face".
> ---
> lisp/cus-edit.el | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
> index f408e83..ca6b8a3 100644
> --- a/lisp/cus-edit.el
> +++ b/lisp/cus-edit.el
> @@ -1334,7 +1334,7 @@ suggest to customize that face, if it's customizable."
> (if (get face 'face-alias)
> (setq face (get face 'face-alias)))
> (unless (facep face)
> - (error "Invalid face %S" face))
> + (user-error "Invalid face %S" face))
> (funcall display-fun
> (list (list face 'custom-face))
> (format "*Customize Face: %s*"
> @@ -4846,8 +4846,6 @@ if that value is non-nil."
>
> (define-obsolete-function-alias 'custom-mode 'Custom-mode "23.1")
>
> -(add-to-list 'debug-ignored-errors "^Invalid face:? ")
> -
> ;;; The End.
>
> (provide 'cus-edit)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master a855473 2/2: Use user-error for customize's "invalid face" error
2017-04-14 0:57 ` master a855473 2/2: Use user-error for customize's "invalid face" error Glenn Morris
@ 2017-04-14 14:11 ` Stefan Monnier
2017-04-14 16:58 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2017-04-14 14:11 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> After committing the following I noticed that you left it out of your
> 71873e2. Do you remember why?
Probably some oversight or manipulation error.
At least I can't remember deciding consciously that this would be undesirable,
and can't see any reason why I'd have decided such a thing either.
Stefan
>> branch: master
>> commit a855473b7079b467ac01dbcee89cb57b3599fdac
>>
>> Use user-error for customize's "invalid face" error
>>
>> * lisp/cus-edit.el (customize-face): Use user-error.
>> (debug-ignored-errors): No more need to add "Invalid face".
>> ---
>> lisp/cus-edit.el | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
>> index f408e83..ca6b8a3 100644
>> --- a/lisp/cus-edit.el
>> +++ b/lisp/cus-edit.el
>> @@ -1334,7 +1334,7 @@ suggest to customize that face, if it's customizable."
>> (if (get face 'face-alias)
>> (setq face (get face 'face-alias)))
>> (unless (facep face)
>> - (error "Invalid face %S" face))
>> + (user-error "Invalid face %S" face))
>> (funcall display-fun
>> (list (list face 'custom-face))
>> (format "*Customize Face: %s*"
>> @@ -4846,8 +4846,6 @@ if that value is non-nil."
>>
>> (define-obsolete-function-alias 'custom-mode 'Custom-mode "23.1")
>>
>> -(add-to-list 'debug-ignored-errors "^Invalid face:? ")
>> -
>> ;;; The End.
>>
>> (provide 'cus-edit)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master a855473 2/2: Use user-error for customize's "invalid face" error
2017-04-14 14:11 ` Stefan Monnier
@ 2017-04-14 16:58 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2017-04-14 16:58 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
>> After committing the following I noticed that you left it out of your
>> 71873e2. Do you remember why?
>
> Probably some oversight or manipulation error. At least I can't
> remember deciding consciously that this would be undesirable, and
> can't see any reason why I'd have decided such a thing either.
OK, thanks for confirming.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-14 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170414001729.26925.43353@vcs0.savannah.gnu.org>
[not found] ` <20170414001730.9292C220BE@vcs0.savannah.gnu.org>
2017-04-14 0:57 ` master a855473 2/2: Use user-error for customize's "invalid face" error Glenn Morris
2017-04-14 14:11 ` Stefan Monnier
2017-04-14 16:58 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.