* Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el
[not found] ` <20171009134716.77ADE201F1@vcs0.savannah.gnu.org>
@ 2017-10-09 15:57 ` Stefan Monnier
2017-10-09 16:18 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2017-10-09 15:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> - (set (make-local-variable (car local))
> - (cdr local)))))
> + ;; Cloning message-default-charset could cause an already
> + ;; encoded text to be encoded again, yielding raw bytes
> + ;; instead of characters in the message.
> + (unless (string-match "message-default-charset"
> + (symbol-name (car local)))
> + (set (make-local-variable (car local))
> + (cdr local))))))
Could you add a comment explaining why we do
(string-match "message-default-charset" (symbol-name (car local))
rather than
(eq 'message-default-charset (car local))
-- Stefan "puzzled"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el
2017-10-09 15:57 ` [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el Stefan Monnier
@ 2017-10-09 16:18 ` Eli Zaretskii
2017-10-09 16:33 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2017-10-09 16:18 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Mon, 09 Oct 2017 11:57:11 -0400
>
> > - (set (make-local-variable (car local))
> > - (cdr local)))))
> > + ;; Cloning message-default-charset could cause an already
> > + ;; encoded text to be encoded again, yielding raw bytes
> > + ;; instead of characters in the message.
> > + (unless (string-match "message-default-charset"
> > + (symbol-name (car local)))
> > + (set (make-local-variable (car local))
> > + (cdr local))))))
>
> Could you add a comment explaining why we do
>
> (string-match "message-default-charset" (symbol-name (car local))
>
> rather than
>
> (eq 'message-default-charset (car local))
No reason except that this was in the patch proposed by Alex. Feel
free to change.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el
2017-10-09 16:18 ` Eli Zaretskii
@ 2017-10-09 16:33 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2017-10-09 16:33 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> No reason except that this was in the patch proposed by Alex.
Good, thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-09 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171009134715.11038.14309@vcs0.savannah.gnu.org>
[not found] ` <20171009134716.77ADE201F1@vcs0.savannah.gnu.org>
2017-10-09 15:57 ` [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el Stefan Monnier
2017-10-09 16:18 ` Eli Zaretskii
2017-10-09 16:33 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.