From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 5b5f441: read_key_sequence: correct the handling of raw_keybuf in recursive calls
Date: Mon, 20 Nov 2017 16:43:52 -0500 [thread overview]
Message-ID: <jwvpo8cljvd.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 20171120203004.GC3917@ACM
>> But this `read_char` is within read_key_sequence: this read_key_sequence
>> may have been called from anywhere, ....
> read_key_sequence is static in keyboard.c, and is called from precisely
> three places: command_loop_1, read_key_sequence_vs, and
> read_menu_command.
Right: the middle one corresponds to `read-key-sequence` which can be
called from "anywhere" (i.e. Elisp).
>> .... so after we exit it (non-locally), we may end up running
>> arbitrary Elisp code before we return to command_loop_1, can't we?
> Is it possible to exit non-locally from read_char (or one of its called
> subroutines)?
`read_char` will run timers and process filters.
See for example `read-key` which calls `read-key-sequence` with a timer
that makes it exit by throwing `read-key` as soon as one key is detected.
> You have a point, here. Perhaps it would be better to get storage from
> the Emacs heap rather than using the stack.
I like using the stack, here, actually.
Maybe another option is to make raw_keybuf local to read_key_sequence,
and to *copy* it into the global raw_keybuf_buffer just before exiting.
Stefan
PS: Of course, even better would be to provide another way to get what
`this-single-command-raw-keys` returns, so we don't need to use a global
variable for it. E.g. have `read-key-sequence` return both the key
sequence and the raw key sequence. But we'd still have to support
`this-single-command-raw-keys` for the foreseeable future anyway.
next prev parent reply other threads:[~2017-11-20 21:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171120181209.23553.97060@vcs0.savannah.gnu.org>
[not found] ` <20171120181210.7946F20416@vcs0.savannah.gnu.org>
2017-11-20 18:41 ` [Emacs-diffs] master 5b5f441: read_key_sequence: correct the handling of raw_keybuf in recursive calls Stefan Monnier
2017-11-20 19:59 ` Alan Mackenzie
2017-11-20 20:09 ` Stefan Monnier
2017-11-20 20:30 ` Alan Mackenzie
2017-11-20 21:43 ` Stefan Monnier [this message]
2017-11-22 19:25 ` Alan Mackenzie
2017-11-22 20:29 ` Stefan Monnier
2017-11-22 21:04 ` Alan Mackenzie
2017-11-23 14:35 ` Stefan Monnier
2017-11-23 18:10 ` Alan Mackenzie
2017-11-23 18:46 ` Stefan Monnier
2017-11-28 18:03 ` Alan Mackenzie
2017-11-28 20:30 ` Eli Zaretskii
2017-12-01 16:48 ` Alan Mackenzie
2017-12-01 18:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpo8cljvd.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.