all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Lifting all buffer restrictions in indentation functions
Date: Fri, 08 Dec 2017 15:47:44 -0500	[thread overview]
Message-ID: <jwvpo7pq7li.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 83shclugwo.fsf@gnu.org

> And I don't think calling indent-line-function directly instead is the
> solution, because indent-according-to-mode, indent-for-tab-command
> etc. are not just trivial wrappers around the call to
> indent-line-function, they have additional functionality (otherwise
> why do we have them at all?).

I can't imagine a scenario where you'd use indent-for-tab-command in
that context.  As for indent-according-to-mode, its only difference with
calling indent-line-function is for pseudo-indentation functions
(indent-relative and friends) where it has an ad-hoc hack to "try and do
the right thing", but it's far from clear what would be The Right Thing
to do in such a narrowed scenario anyway (call indent-line-function
directly, use the ad-hoc hack, or do yet something else).

Most cases of calling indent-line-function or indent-according-to-mode
when indent-line-function is one of those pseudo-indentation functions
don't really do the right thing anyway.

So it sounds highly hypothetical, and it's not clear if would be more
often right or more often wrong in those hypothetical cases.


        Stefan




  reply	other threads:[~2017-12-08 20:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 16:51 Lifting all buffer restrictions in indentation functions Eli Zaretskii
2017-12-08 17:03 ` Stefan Monnier
2017-12-08 20:02   ` Eli Zaretskii
2017-12-08 20:47     ` Stefan Monnier [this message]
2017-12-09  8:24       ` Eli Zaretskii
2017-12-09 15:19         ` Stefan Monnier
2017-12-08 17:38 ` Robert Weiner
2017-12-08 17:50   ` Stefan Monnier
2017-12-08 22:40 ` Stephen Leake
2017-12-08 22:49   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpo7pq7li.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.