From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "Johan Bockgård" <bojohan@gnu.org>, emacs-devel@gnu.org
Subject: Re: `aset` on strings, changing the size in bytes
Date: Fri, 07 Sep 2018 22:04:36 -0400 [thread overview]
Message-ID: <jwvpnxopx7s.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f547e62f-690c-ab1c-16f8-4f94b84ca9ff@cs.ucla.edu> (Paul Eggert's message of "Fri, 7 Sep 2018 16:12:07 -0700")
>> According to the documentation, that is already an error...
>> (info "(elisp) Modifying Strings")
> Cool! That means we can do Stefan's request simply by reverting Kenichi
> Handa's patch that introduced the ability to change the byte length
> of a string (commit 3c9de1afcde82a99137721436c822059cce79b5b dated
> 2000-07-21 06:45:30 UTC), since that patch made the code explicitly disagree
> with the documentation.
It's very easy to accidentally use that feature, so just because it was
in some doc somewhere doesn't mean no code makes use of it, or that any
code that does deserves to get an error.
So we can't just revert that patch. We should first announce the
reversal of stance (if not compared to the doc, at least compared to
the code), and then introduce some test&warning.
> Though this leaves open the question of why Handa made that change in
> the first place.
I remember being disappointed by the change, but I can't remember
exactly what was the original justification. I think the stance was
simply that it was reasonably easy to implement (because of the
pre-existing string-compaction code) and it would satisfy
a user request.
Stefan
next prev parent reply other threads:[~2018-09-08 2:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 19:52 `aset` on strings, changing the size in bytes Stefan Monnier
2018-09-07 21:33 ` Johan Bockgård
2018-09-07 23:12 ` Paul Eggert
2018-09-07 23:41 ` John Wiegley
2018-09-08 5:17 ` Richard Stallman
2018-09-08 6:34 ` Eli Zaretskii
2018-09-08 2:04 ` Stefan Monnier [this message]
2018-09-08 2:17 ` Paul Eggert
2018-09-08 6:41 ` Eli Zaretskii
2018-09-08 18:03 ` Stefan Monnier
2018-09-08 18:20 ` Eli Zaretskii
2018-09-08 18:36 ` Stefan Monnier
2018-09-08 20:59 ` Eli Zaretskii
2018-09-08 22:09 ` Stefan Monnier
2018-09-09 5:22 ` Eli Zaretskii
2018-09-10 0:18 ` Stefan Monnier
2018-09-09 6:07 ` Richard Stallman
2018-09-09 6:26 ` Eli Zaretskii
2018-09-09 14:44 ` Noam Postavsky
2018-09-09 15:17 ` Eli Zaretskii
2018-09-09 16:27 ` Noam Postavsky
2018-09-10 5:48 ` Richard Stallman
2018-09-10 3:03 ` Stefan Monnier
2018-10-16 21:05 ` Stefan Monnier
2018-09-10 5:47 ` Richard Stallman
2018-09-10 5:48 ` Richard Stallman
2018-09-10 3:02 ` Stefan Monnier
2018-09-08 6:03 ` Helmut Eller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpnxopx7s.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bojohan@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.