From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: syntax based indentation for SQL files (ELPA package proposal) Date: Tue, 02 Oct 2018 08:57:02 -0400 Message-ID: References: <808t48ny4y.fsf@gmail.com> <86a7nxb8p8.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1538484951 10132 195.159.176.226 (2 Oct 2018 12:55:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2018 12:55:51 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 14:55:47 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7KDK-0002Xt-Lx for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 14:55:46 +0200 Original-Received: from localhost ([::1]:43616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7KFR-0003JB-EA for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 08:57:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7KEm-0003Iu-Vz for emacs-devel@gnu.org; Tue, 02 Oct 2018 08:57:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7KEj-0004JO-O6 for emacs-devel@gnu.org; Tue, 02 Oct 2018 08:57:16 -0400 Original-Received: from [195.159.176.226] (port=59703 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7KEj-0004Hq-6U for emacs-devel@gnu.org; Tue, 02 Oct 2018 08:57:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1g7KCX-0001Zb-KU for emacs-devel@gnu.org; Tue, 02 Oct 2018 14:54:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:SBqaT2OIH+i3dkynw3NP0mf92R4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230189 Archived-At: > This patch looks like it has been applied in the wrong place. Emacs > builtin code should not depend on an external package. Why did you add > this change into emacs, rather than the package that defines > sqind-minor-mode ? It doesn't actually depend on sql-indent. It just makes use of it when available. Given that sql-indent is in GNU ELPA, I think this is perfectly acceptable (and I'm pretty sure we have other similar cases already in emacs.git, some of which for packages that aren't even in GNU ELPA). Stefan