From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Phil Sainty <psainty@orcon.net.nz>
Subject: Re: [Emacs-diffs] scratch/so-long 7273fb2: Add so-long library
Date: Thu, 10 Jan 2019 13:07:25 -0500 [thread overview]
Message-ID: <jwvpnt4jtax.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20190107065208.BA36C21736@vcs0.savannah.gnu.org> (Phil's message of "Mon, 7 Jan 2019 01:52:08 -0500 (EST)")
> +FIXME: +++ once all documentation has been added.
No need for this FIXME: the whole point of this system is that you don't
need to do anything special to mark entries as "not yet handled" (any `**`
header without a preceding `---` or `+++` has not been handled yet), so
it's "fail safe".
> +;; Installation
> +;; ------------
> +;; And add the following to your init file to enable the library:
> +;;
> +;; (when (require 'so-long nil :noerror)
> +;; (so-long-enable))
I think the above should just be
(so-long-auto-mode 1)
and so-long-auto-mode (just my suggestion for a name, feel free to
chose something else) should be an autoloaded global minor mode which
activates so-long-mode.
On the design side, I think you should merge `so-long` and
`so-long-mode` into a single function and make that function
a (buffer-local) minor-mode (i.e. not have any major mode, just use
fundamental-mode instead). Making it a minor mode rather than
a major-mode will also make it easier to remember the previous
major-mode without any need for a change-major-mode-hook hack.
> +(defvar so-long-enabled t
> + "Set to nil to prevent `so-long' from being triggered automatically.")
Loading a file should not change the behavior of Emacs, so the default
should be nil unless/until we decide to preload this package.
Rather than defadvice, please use advice-add.
Other than that, looks great, thanks.
Stefan
next parent reply other threads:[~2019-01-10 18:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190107065207.21793.53271@vcs0.savannah.gnu.org>
[not found] ` <20190107065208.BA36C21736@vcs0.savannah.gnu.org>
2019-01-10 18:07 ` Stefan Monnier [this message]
2019-01-12 2:20 ` [Emacs-diffs] scratch/so-long 7273fb2: Add so-long library Phil Sainty
2019-01-12 15:11 ` Stefan Monnier
2019-01-12 21:01 ` Stefan Monnier
2019-04-14 13:09 ` Phil Sainty
2019-04-14 15:14 ` Stefan Monnier
2019-04-14 22:33 ` Phil Sainty
2019-06-27 13:46 ` Performance degradation from long lines Phil Sainty
2019-07-06 14:18 ` Phil Sainty
2019-07-13 8:07 ` Eli Zaretskii
2019-07-13 9:07 ` Stefan Kangas
2019-07-13 9:51 ` Eli Zaretskii
2019-07-13 10:23 ` Stefan Kangas
2019-07-13 10:29 ` Eli Zaretskii
2019-07-13 10:38 ` Stefan Kangas
2019-07-13 10:58 ` Phil Sainty
2019-07-13 11:23 ` Eli Zaretskii
2019-07-13 11:23 ` Eli Zaretskii
2019-07-13 9:33 ` Phil Sainty
2019-07-13 9:56 ` Eli Zaretskii
2019-07-13 13:31 ` Stefan Monnier
2019-07-13 13:43 ` Stefan Kangas
2019-07-13 14:14 ` Eli Zaretskii
2019-07-13 14:17 ` Stefan Monnier
2019-07-13 18:17 ` Eli Zaretskii
2019-07-13 22:22 ` Stefan Monnier
2019-07-14 5:39 ` Eli Zaretskii
2019-07-15 13:12 ` Dmitry Gutov
2019-07-18 6:30 ` Eli Zaretskii
2019-07-18 14:48 ` Stefan Monnier
2019-07-18 17:11 ` Clément Pit-Claudel
2019-07-18 18:11 ` Stefan Monnier
2019-07-18 18:33 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpnt4jtax.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.