From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alan Mackenzie <acm@muc.de>,
daniel.lopez999@gmail.com, 34525@debbugs.gnu.org
Subject: bug#34525: replace-regexp missing some matches
Date: Wed, 27 Feb 2019 12:41:04 -0500 [thread overview]
Message-ID: <jwvpnrdb0xj.fsf-monnier+emacsbugs__18779.3226608605$1551289376$gmane$org@gnu.org> (raw)
In-Reply-To: <838sy1kwxo.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Feb 2019 18:39:31 +0200")
> next_interval and previous_interval are used extensively, so I'm
> having hard time believing that they have such a blatant bug.
I'm also wondering why this hasn't bitten us long ago, but the behavior
in the original bug-report is definitely weird.
E.g. I reproduced the bug using the lower-level (while
(re-search-forward RE) (replace-match)), and then added (how-many RE)
calls before re-search-forward and before replace-match: these should
always differ by 1 (since one occurrence of RE was skipped by
re-search-forward), but they often didn't (even though there was no
buffer modifications between the two how-many calls).
AFAICT the only place where the missing updates can bite us is when we
call update_interval, since it seems to be the only function that relies
on all parents having the ->position field correctly set.
update_interval is only called from update_syntax_table.
I'm actually wondering whether we should keep update_interval at all:
AFAICT update_syntax_table is almost always called "sequentially".
I.e. the new `charpos` is right next to the old one. So a while loop
with next_interval/previous_interval should be just as efficient in
practice: a loop of next_interval/previous_interval has basically
a complexity O(n) where `n` is the distance we move, whereas
update_interval has complexity O(log n), so if `n` is almost always
1 the difference doesn't matter.
Stefan
next prev parent reply other threads:[~2019-02-27 17:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 8:28 bug#34525: replace-regexp missing some matches Daniel Lopez
[not found] ` <handler.34525.B.15504786524313.ack@debbugs.gnu.org>
2019-02-18 8:37 ` bug#34525: Acknowledgement (replace-regexp missing some matches) Daniel Lopez
2019-02-18 15:50 ` bug#34525: replace-regexp missing some matches Eli Zaretskii
2019-02-18 16:46 ` Alan Mackenzie
2019-02-18 21:10 ` Alan Mackenzie
2019-02-20 17:07 ` Alan Mackenzie
[not found] ` <20190220170722.GA9655@ACM>
2019-02-20 18:02 ` Eli Zaretskii
2019-02-20 18:58 ` Alan Mackenzie
2019-02-20 19:27 ` Eli Zaretskii
2019-02-20 21:30 ` Alan Mackenzie
[not found] ` <20190220213003.GC9655@ACM>
2019-02-21 3:40 ` Eli Zaretskii
2019-02-24 17:37 ` Alan Mackenzie
2019-02-24 17:56 ` Eli Zaretskii
2019-02-24 21:00 ` Alan Mackenzie
2019-02-25 20:11 ` Eli Zaretskii
2019-02-25 20:48 ` Alan Mackenzie
2019-02-26 13:50 ` Alan Mackenzie
[not found] ` <20190226135048.GA19653@ACM>
2019-02-26 15:00 ` Alan Mackenzie
2019-02-26 15:39 ` Eli Zaretskii
2019-02-26 16:11 ` Alan Mackenzie
2019-02-26 16:42 ` Eli Zaretskii
2019-02-26 16:55 ` Alan Mackenzie
[not found] ` <20190226165505.GD19653@ACM>
2019-02-26 17:20 ` Eli Zaretskii
2019-02-26 17:23 ` Alan Mackenzie
2019-02-26 15:36 ` Eli Zaretskii
2019-02-26 20:09 ` Stefan Monnier
2019-02-26 23:00 ` Stefan Monnier
[not found] ` <jwv8sy2z5yc.fsf-monnier+emacsbugs@gnu.org>
2019-02-26 21:45 ` Alan Mackenzie
2019-02-26 22:09 ` Stefan Monnier
2019-02-27 14:22 ` Alan Mackenzie
[not found] ` <20190227142251.GB4772@ACM>
2019-02-27 15:08 ` Alan Mackenzie
[not found] ` <20190227150849.GC4772@ACM>
2019-02-27 15:40 ` Stefan Monnier
2019-02-27 17:10 ` Alan Mackenzie
2019-02-27 16:39 ` Eli Zaretskii
2019-02-27 17:31 ` Alan Mackenzie
2019-02-27 17:41 ` Stefan Monnier [this message]
[not found] ` <20190227173132.GG4772@ACM>
2019-02-27 18:07 ` Eli Zaretskii
2019-02-28 10:50 ` Alan Mackenzie
2019-02-28 17:41 ` Eli Zaretskii
2019-02-28 21:54 ` Alan Mackenzie
[not found] ` <jwvpnrdb0xj.fsf-monnier+emacsbugs@gnu.org>
2019-02-27 18:48 ` Eli Zaretskii
2019-02-27 20:43 ` Alan Mackenzie
2019-02-20 21:25 ` Daniel Lopez
2019-02-22 16:26 ` Alan Mackenzie
2019-03-01 14:34 ` Alan Mackenzie
[not found] ` <20190301143414.GD5674@ACM>
2019-03-01 17:58 ` Daniel Lopez
2019-03-01 17:42 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvpnrdb0xj.fsf-monnier+emacsbugs__18779.3226608605$1551289376$gmane$org@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=34525@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=daniel.lopez999@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.