From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures Date: Sun, 17 Nov 2019 15:13:56 -0500 Message-ID: References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176222"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38206@debbugs.gnu.org, Braun =?UTF-8?Q?G=C3=A1bor?= To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 21:15:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWQx4-000jh9-4i for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 21:15:18 +0100 Original-Received: from localhost ([::1]:56162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWQx2-0007Xw-IZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 15:15:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58966) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWQwp-0007VL-GC for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:15:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWQwo-0005oN-6A for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWQwo-0005oH-2R for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWQwn-000712-P8 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38206 X-GNU-PR-Package: emacs Original-Received: via spool by 38206-submit@debbugs.gnu.org id=B38206.157402164926896 (code B ref 38206); Sun, 17 Nov 2019 20:15:01 +0000 Original-Received: (at 38206) by debbugs.gnu.org; 17 Nov 2019 20:14:09 +0000 Original-Received: from localhost ([127.0.0.1]:42715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQvw-0006zj-RM for submit@debbugs.gnu.org; Sun, 17 Nov 2019 15:14:09 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQvv-0006zV-Dr for 38206@debbugs.gnu.org; Sun, 17 Nov 2019 15:14:07 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 15F4D449EC7; Sun, 17 Nov 2019 15:14:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C7C81449EA9; Sun, 17 Nov 2019 15:14:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1574021640; bh=buxQ8NyhIGez9tIpUZcXOfnLwLaYHsqHDcnXBN924z4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Uo+l80Hq5MCr3oMEd+vVWGVjB8lEZyPWYnbEdNlZRC9udtQCYV7fAzEN7UhDe+0N4 FqlcP4ezoUF0AhSoe7FLd+zhds7NP34YJsY8OWb3mSastMEOxH/gYwSl6fwCDvnBQr s+zEjDlsUJ6Qtbnm+rqO167PZSWYas5J2wOLQ+tbXnoxg2gpYO+y07JadluC374QUk A73yZl3c/5S72ODHRJmKTaRoSxz/M+QakG5im8H7kbsird/9LJv2vp/X43Fezhk2LK Eoi9lHZRYwWcnuOulid9KJTCC21bX3WitmTa7BVF07JrWineuNgVT0tZUxk/ubVOs2 ogrHolmysi7zA== Original-Received: from alfajor (unknown [216.154.18.30]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6C2B612084D; Sun, 17 Nov 2019 15:14:00 -0500 (EST) In-Reply-To: <87imniux7l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 20:19:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171853 Archived-At: > The bug was introduced by a rewrite in 2012, I think, which changed the > implementation radically, which made it pass in that list as a totally > bogus ENVIRONMENT to macroexpand-all. Not sure why you see it that way. `C-x v h` tells me: commit 6fa6c4aedbc9f33cf8ed67fdb7794c3b4ff6660a Author: Stefan Monnier Date: Thu Jun 7 15:48:22 2012 -0400 Move old compatiblity to cl.el. Remove cl-macroexpand-all. [...] diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el --- a/lisp/emacs-lisp/cl-extra.el +++ b/lisp/emacs-lisp/cl-extra.el @@ -798,2 +681,2 @@ - (setq form (cl-macroexpand-all form - (and (not full) '((cl-block) (cl-eval-when))))) + (setq form (macroexpand-all form + (and (not full) '((cl-block) (cl-eval-when))))) commit 7c1898a7b93053cd0431f46f02d82c0a31bfb8bf Author: Stefan Monnier Date: Sun Jun 3 21:05:17 2012 -0400 * lisp/emacs-lisp/cl-lib.el: Rename from cl.el. * lisp/emacs-lisp/cl.el: New compatibility file. * emacs-lisp/cl-lib.el, lisp/emacs-lisp/cl-seq.el, lisp/emacs-lisp/cl-macs.el: * lisp/emacs-lisp/cl-extra.el: Rename all top-level functions and variables to obey the "cl-" prefix. * lisp/emacs-lisp/macroexp.el (macroexpand-all-1): Adjust to new name. diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el --- a/lisp/emacs-lisp/cl-extra.el +++ b/lisp/emacs-lisp/cl-extra.el @@ -802,2 +798,2 @@ (setq form (cl-macroexpand-all form - (and (not full) '((block) (eval-when))))) + (and (not full) '((cl-block) (cl-eval-when))))) commit fcd737693e8e320acd70f91ec8e0728563244805 Author: Richard M. Stallman Date: Fri Jul 30 20:15:09 1993 +0000 entered into RCS diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el --- /dev/null +++ b/lisp/emacs-lisp/cl-extra.el @@ -0,0 +920,2 @@ + (setq form (cl-macroexpand-all form + (and (not full) '((block) (eval-when))))) so it seems that it's been with us since at least 1993. > I think the right change here is to just deprecate the FULL parameter > and remove the > > (and (not full) '((cl-block) (cl-eval-when))))) > > bit. Stefan? 100% agreement. Stefan