From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 38206@debbugs.gnu.org, "Braun Gábor" <braungb88@gmail.com>
Subject: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures
Date: Sun, 17 Nov 2019 15:13:56 -0500 [thread overview]
Message-ID: <jwvpnhq9sa0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87imniux7l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 20:19:58 +0100")
> The bug was introduced by a rewrite in 2012, I think, which changed the
> implementation radically, which made it pass in that list as a totally
> bogus ENVIRONMENT to macroexpand-all.
Not sure why you see it that way. `C-x v h` tells me:
commit 6fa6c4aedbc9f33cf8ed67fdb7794c3b4ff6660a
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Thu Jun 7 15:48:22 2012 -0400
Move old compatiblity to cl.el. Remove cl-macroexpand-all.
[...]
diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el
--- a/lisp/emacs-lisp/cl-extra.el
+++ b/lisp/emacs-lisp/cl-extra.el
@@ -798,2 +681,2 @@
- (setq form (cl-macroexpand-all form
- (and (not full) '((cl-block) (cl-eval-when)))))
+ (setq form (macroexpand-all form
+ (and (not full) '((cl-block) (cl-eval-when)))))
commit 7c1898a7b93053cd0431f46f02d82c0a31bfb8bf
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Sun Jun 3 21:05:17 2012 -0400
* lisp/emacs-lisp/cl-lib.el: Rename from cl.el.
* lisp/emacs-lisp/cl.el: New compatibility file.
* emacs-lisp/cl-lib.el, lisp/emacs-lisp/cl-seq.el, lisp/emacs-lisp/cl-macs.el:
* lisp/emacs-lisp/cl-extra.el: Rename all top-level functions and variables
to obey the "cl-" prefix.
* lisp/emacs-lisp/macroexp.el (macroexpand-all-1): Adjust to new name.
diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el
--- a/lisp/emacs-lisp/cl-extra.el
+++ b/lisp/emacs-lisp/cl-extra.el
@@ -802,2 +798,2 @@
(setq form (cl-macroexpand-all form
- (and (not full) '((block) (eval-when)))))
+ (and (not full) '((cl-block) (cl-eval-when)))))
commit fcd737693e8e320acd70f91ec8e0728563244805
Author: Richard M. Stallman <rms@gnu.org>
Date: Fri Jul 30 20:15:09 1993 +0000
entered into RCS
diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el
--- /dev/null
+++ b/lisp/emacs-lisp/cl-extra.el
@@ -0,0 +920,2 @@
+ (setq form (cl-macroexpand-all form
+ (and (not full) '((block) (eval-when)))))
so it seems that it's been with us since at least 1993.
> I think the right change here is to just deprecate the FULL parameter
> and remove the
>
> (and (not full) '((cl-block) (cl-eval-when)))))
>
> bit. Stefan?
100% agreement.
Stefan
next prev parent reply other threads:[~2019-11-17 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:20 bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures Braun Gábor
2019-11-17 19:19 ` Lars Ingebrigtsen
2019-11-17 20:13 ` Stefan Monnier [this message]
2019-11-17 20:19 ` Lars Ingebrigtsen
2019-11-17 22:02 ` Stefan Monnier
2019-11-18 10:00 ` Lars Ingebrigtsen
2019-11-20 16:26 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpnhq9sa0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=38206@debbugs.gnu.org \
--cc=braungb88@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.