From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119)
Date: Wed, 25 Mar 2020 16:54:26 -0400 [thread overview]
Message-ID: <jwvpnd040rn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200325204157.3643820E43@vcs0.savannah.gnu.org> ("Mattias Engdegård"'s message of "Wed, 25 Mar 2020 16:41:56 -0400 (EDT)")
> +(defcustom compilation-error-case-fold-search nil
> + "If non-nil, use case-insensitive matching of compilation errors
> +by the regexps of `compilation-error-regexp-alist' and
> +`compilation-error-regexp-alist-alist'.
> +If nil, matching is case-sensitive."
> + :type 'boolean
> + :version "28.1")
This makes no sense as a user-config.
The regular expressions are written either with or without case-folding
in mind, so changing it globally is a recipe for problems.
If we want to allow case-insensitive regexp matching, then we should
extend the syntax of `compilation-error-regexp-alist` so that a given
entry there can request it to be used with case-folding.
Stefan
PS: The same applies to the "zero/one-based column numbers" and
the "char-colums vs visual-columns vs byte-columns", admittedly.
next parent reply other threads:[~2020-03-25 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200325204155.5002.75177@vcs0.savannah.gnu.org>
[not found] ` <20200325204157.3643820E43@vcs0.savannah.gnu.org>
2020-03-25 20:54 ` Stefan Monnier [this message]
2020-03-25 22:29 ` master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119) Mattias Engdegård
2020-03-26 3:42 ` Stefan Monnier
2020-03-26 16:25 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpnd040rn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.