From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#37127: [PATCH] cperl-mode: Suppress a misleading message Date: Fri, 30 Oct 2020 10:30:04 -0400 Message-ID: References: <87ftlu67cy.fsf@vinc17.net> <87eelg3ffl.fsf@hajtower> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36191"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 37127@debbugs.gnu.org To: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 15:32:54 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYVSX-0009HS-OC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 15:32:54 +0100 Original-Received: from localhost ([::1]:45824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYVSW-0001Qp-OB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 10:32:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYVQk-000842-PY for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYVQk-0001Oo-CK for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYVQk-0002fw-8H for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed Original-Received: via spool by 37127-submit@debbugs.gnu.org id=B37127.16040682268131 (code B ref 37127); Fri, 30 Oct 2020 14:31:02 +0000 Original-Received: (at 37127) by debbugs.gnu.org; 30 Oct 2020 14:30:26 +0000 Original-Received: from localhost ([127.0.0.1]:59177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVQA-00026q-64 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 10:30:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVQ4-0001v1-Uk for 37127@debbugs.gnu.org; Fri, 30 Oct 2020 10:30:21 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1A2BF80BCE; Fri, 30 Oct 2020 10:30:15 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C4FC9809A7; Fri, 30 Oct 2020 10:30:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604068213; bh=xKEdAJU6WI1pjdOtzlsZ6AfbXrzwLP6gHNTmizhcZzg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YwouP8Ijnao1jwLwQiwP+nr1eqRpSftRocuRBGpJBetl6r16OIxD7/19iyxFFXeXl SrUgmhto4Z+Z7dw5XmEvLWsxdJW5Y31itDp+ij7INpLBDcMN/VU7HFV3vNzltONnz5 2USfFwFzt2IAJVxkk2qOAceDx8hbQBx24WNjKIALVePNuIp7BIXjiDm8nmQQXpmVR4 HnmRWixlTHKKl1YHibQwAlYcIoZcNjU1UEuyBI8xjotJQUW3zdzIOmwn9tSiVtgJee KFh9oLnxVX+O9bwWLjGnr/M+yOepYgPgBkj/bDi/wPnNqJBAeiKTNsSUCryWvUyAMK jnUQ1ODVy6AKg== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3BD24120205; Fri, 30 Oct 2020 10:30:13 -0400 (EDT) In-Reply-To: <87eelg3ffl.fsf@hajtower> ("Harald =?UTF-8?Q?J=C3=B6rg?="'s message of "Thu, 29 Oct 2020 22:11:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192116 Archived-At: > +(ert-deftest cperl-bug37127 () [...] > + ;; part two: Regex terminator missing -> message > + (ert-with-message-capture collected-messages > + (with-temp-buffer > + (insert "$_ =~ /(..;") > + (goto-char (point-min)) > + (cperl-mode) > + (search-forward ".") > + (let ((last-command-event ?\))) > + (cperl-electric-rparen 1) > + (cperl-find-pods-heres (point-min) (point-max) t))) > + (should (string-match "^End of .* string/RE" > + collected-messages))))) Why is this behavior desirable? I mean, I don't necessarily mind it, but as a user I find it odd that typing a `)` which has a matching `(` nearby (which can be found without crossing any string/RE boundary) should emit a warning about some "unrelated" surrounding entity like the RE in which it is located. Emacs usually doesn't emit any such warning when editing within an unclosed string. I don't think we should necessarily change CPerl's behavior in this regard, but that we shouldn't consider it a feature and thus shouldn't enforce it in our tests. Stefan