From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/pyim 952814a 1/2: * pyim.el (pyim-cregexp-build): handle the case, when regexp generated is too long. Date: Mon, 15 Mar 2021 10:12:34 -0400 Message-ID: References: <20210315075708.17408.32347@vcs0.savannah.gnu.org> <20210315075709.C859C20DFD@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15483"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Feng Shu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 15 15:16:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLo1b-0003te-Ff for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Mar 2021 15:16:51 +0100 Original-Received: from localhost ([::1]:56506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLo1a-0001FJ-Fw for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Mar 2021 10:16:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLnxY-00063u-W8 for emacs-devel@gnu.org; Mon, 15 Mar 2021 10:12:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLnxW-0005cV-Nt for emacs-devel@gnu.org; Mon, 15 Mar 2021 10:12:40 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 60F87440EEC; Mon, 15 Mar 2021 10:12:37 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 88F3A440DCF; Mon, 15 Mar 2021 10:12:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615817555; bh=kaFEHHIwNwk+BVLDi/7fO4VFrBAT9Qi3dZVfyQR2fbE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DFPe/ocV/IB/ohpJ5dekDubUR/b9dTvoWJ2phjOHU8u7tbk63J3chf7SGp/HF5ZM/ LncGQulEdD3xoSxmAx9iJn/MMU/8rXDbrbbtmYk5xpRhH+RVdVQgm+yfz4O0QLwMPL n/gJEdyikkfFkGnG+87C1FdAa4jlAcOBynH7ahl07f3dFx3CSOuIn/pnqebTACUNSh Z9Cixhnaw/JpH6Wq1HM/frmV+XFlKGo40a0eVwmfYZ+xeJ17P1VvuEofgiQPwuhd3L xEXPZgoet6alXwIutGSiRYj961w6OaIPcDi+i9aKzxdyQKShIMgFTmR+AtA1dmV098 V41zSBv4bmkXg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 659BE12047D; Mon, 15 Mar 2021 10:12:35 -0400 (EDT) In-Reply-To: <20210315075709.C859C20DFD@vcs0.savannah.gnu.org> (ELPA Syncer's message of "Mon, 15 Mar 2021 03:57:09 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266482 Archived-At: > + (stringp rx-string) > + ;; FIXME: Emacs seem to can not handle regexp, which length is too big. > + (length< rx-string 5000)) The limit is not in the actual string's length but in the generated compiled-regexp object (it basically compiles regexps to a dedicated bytecode format whose "jumps" use 16bit relative offsets making it break down when the bytecode object gets larger than about 32KB). I suggest you use a test like (condition-case nil (progn (string-match rx-string "") 'good) ;; FIXME: Emacs can't handle regexps whose length is too big :-( (error 'bad)) -- Stefan