From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Arthur Miller <arthur.miller@live.com>
Cc: emacs-devel@gnu.org
Subject: Re: Partial wdired (edit just filename at the point)
Date: Fri, 19 Mar 2021 12:18:58 -0400 [thread overview]
Message-ID: <jwvpmzv8esx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AM9PR09MB4977D4E3E2405E9D35F76AD596689@AM9PR09MB4977.eurprd09.prod.outlook.com> (Arthur Miller's message of "Fri, 19 Mar 2021 12:15:57 +0100")
> Indeed, I was only concentrated on "interactive" editing, didn't thought
> so much of other elisp functions.
That's the advantage of `before-change-functions`: you just don't need
to think about all the many different cases.
> Jere is a sketch with region, however, I am not able to get
> editing permissions correctly. I am not really sure what is going on.
I assume you tried with `(setq wdired-allow-to-change-permissions t)`.
I think I see what's going on:
- I go to the permissions of a "fresh" line (one that hasn't yet been
processed by `wdired--before-change-fn`).
- I hit `x` with the intention to toggle the execute bit.
- Because it's "fresh" there's no keymap set so the key lookup decides
I want to run `self-insert-command` rather than `wdired-set-bit`.
- Then we see another problem: the "read-only" test is performed before
running the `before-change-functions` so the insertion of `x` is
allowed even though we will end up placing a `read-only` property over
that text just before the `x` is actually inserted.
I see other problems linked to this ordering problem:
- Go to the "non-editable" part of a "fresh" line.
- Hit `C-y`
- The yank is happily accepted.
- Worse: the text we yanked doesn't have the `read-only` property so you
can keep modifying it (tho the rest of line now is marked `read-only`).
Hmm....
Stefan
next prev parent reply other threads:[~2021-03-19 16:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 18:23 Partial wdired (edit just filename at the point) Arthur Miller
2021-03-17 1:18 ` Stefan Monnier
2021-03-17 2:21 ` Arthur Miller
2021-03-17 2:34 ` Stefan Monnier
2021-03-17 13:58 ` Arthur Miller
2021-03-17 14:09 ` Stefan Monnier
2021-03-17 19:56 ` Arthur Miller
2021-03-17 22:40 ` Arthur Miller
2021-03-18 2:10 ` Stefan Monnier
2021-03-18 10:26 ` Arthur Miller
2021-03-18 10:32 ` Thierry Volpiatto
2021-03-18 11:00 ` Arthur Miller
2021-03-18 11:11 ` Thierry Volpiatto
2021-03-18 11:46 ` Arthur Miller
2021-03-23 23:32 ` Michael Heerdegen
2021-03-18 14:21 ` Stefan Monnier
2021-03-19 11:15 ` Arthur Miller
2021-03-19 16:18 ` Stefan Monnier [this message]
2021-03-19 20:40 ` Sv: " arthur miller
2021-03-19 21:58 ` Stefan Monnier
2021-03-20 11:23 ` Sv: " arthur miller
2021-03-21 22:17 ` Tomas Hlavaty
2021-03-22 8:12 ` tomas
2021-03-22 12:44 ` Arthur Miller
2021-03-22 14:50 ` tomas
2021-03-22 13:11 ` Stefan Monnier
2021-03-22 20:08 ` Tomas Hlavaty
2021-03-22 20:28 ` Andreas Schwab
2021-03-22 21:00 ` Stefan Monnier
2021-03-22 21:52 ` Tomas Hlavaty
2021-03-22 22:16 ` Stefan Monnier
2021-03-22 22:39 ` Tomas Hlavaty
2021-03-22 23:27 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpmzv8esx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=arthur.miller@live.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.