From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: "Augusto Stoffel" <arstoffel@gmail.com>,
"Fabián E. Gallina" <fgallina@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Python and Tramp
Date: Fri, 04 Feb 2022 13:36:40 -0500 [thread overview]
Message-ID: <jwvpmo2a39a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87lf2he0wu.fsf@gmx.de> (Michael Albinus's message of "Mon, 25 Oct 2021 14:36:49 +0200")
Michael Albinus [2021-10-25 14:36:49] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think, when reading the python.el code, I'm bothered by 2 things:
>> - the presence of Tramp code, of course.
>> - the fact that I can't clearly see what is the intention of that code
>> because it is intermingled with Tramp code.
> See my other message. Both shouldn't be needed.
>> I suggest we start by changing
>> `python-shell-calculate-process-environment` so it doesn't return the
>> full environment, but only the entries that should be added to the
>> environment. This should make it possible to write it without any
>> Tramp code.
> Yes.
>> Also we should split `python-shell-with-environment` into the Tramp and
>> the non-Tramp case (there's very little overlap). E.g. the code below
>> has most of the Tramp-specific code confined to functions that have
>> `tramp` in their name and which mostly (but not quite ;-( ) don't know
>> about Python.
> Could we start with your patch? That means, could you push it to master?
Of course. Done.
> I would continue then with my proposals from the other message.
I count on you to do it as promptly as I just did ;-)
Stefan
prev parent reply other threads:[~2022-02-04 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwv1r52i1ay.fsf-monnier+emacs@gnu.org>
[not found] ` <87czomrs81.fsf@gmx.de>
[not found] ` <87h7dyvx29.fsf@gmail.com>
[not found] ` <jwvpmslhl0p.fsf-monnier+emacs@gnu.org>
[not found] ` <87fst9xgbu.fsf@gmail.com>
2021-10-25 12:31 ` Python and Tramp Michael Albinus
2021-10-25 12:36 ` Michael Albinus
2022-02-04 18:36 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpmo2a39a.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=arstoffel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=fgallina@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.