From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master b299c04201: Fix computation of outline heading level for non-git diff Date: Sun, 20 Feb 2022 09:36:25 -0500 Message-ID: References: <164503923630.1044.8899541087881650110@vcs2.savannah.gnu.org> <20220216192037.2F236C00894@vcs2.savannah.gnu.org> <8735kim00e.fsf@gmail.com> <87tucuklt2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38143"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Matthias Meulien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 20 15:37:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLnLT-0009kJ-82 for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Feb 2022 15:37:51 +0100 Original-Received: from localhost ([::1]:41080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLnLR-0003xV-PI for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Feb 2022 09:37:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLnKH-0003HN-Qn for emacs-devel@gnu.org; Sun, 20 Feb 2022 09:36:37 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27277) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLnKE-0005bX-V3 for emacs-devel@gnu.org; Sun, 20 Feb 2022 09:36:37 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C8F0E100189; Sun, 20 Feb 2022 09:36:32 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1163710012E; Sun, 20 Feb 2022 09:36:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645367787; bh=WWG/Pq2A/M41MSnYkcl0EI12RkSAZfUchQRzPogptNE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NY26jdUw05tJgobA21uTPhP1DtkwRaWKDllM5DvNmdM7DhF1XjcCxyzV6kDmR+Ia4 ZQ7yM1zi6cN6av8Um/eUFlLPE2lS2cTaOPQ2EwwKEItXGQOW1AkwW+rvM71aSu5GBz a94ApEfEu5AfRxXHwyIJGEdwWimEUJmeF3U9ylwM/PyBdKDq7OgehtbilGtMQmpf34 v/LU9wc6LTe7rfeaPVpVRGm43G7FxvF7pMkGDSJdji0il/IxtPobbwrOrzoxzh6jVt SQViGCfDdy6FKK3nmqQjvek5My0/+IgJloqHunJGR4LgxrIEaCYb85NqMlIdRDMB/Z GMvQ7052Ti/cQ== Original-Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B8393120510; Sun, 20 Feb 2022 09:36:26 -0500 (EST) In-Reply-To: <87tucuklt2.fsf@gmail.com> (Matthias Meulien's message of "Sun, 20 Feb 2022 09:02:33 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286517 Archived-At: Matthias Meulien [2022-02-20 09:02:33] wrote: > Stefan Monnier writes: >> Ah, thanks. I just pushed a patch which should fix it. > Can you confirm that for the patch file I submitted, after your fix is > applied, `diff--font-lock-prettify' is now supposed to do nothing? Not quite. My patch fixes the error that incorrectly moved the first `+` and `-` of the file header to the fringe. IOW the result is that on non-Git diffs, `diff--font-lock-prettify` will still move the `+` and `-` of the diffs into the fringe, but it will leave the rest (most importantly the file headers) untouched. > (Just in case =F0=9F=98=89 there're other cases where prettifying diff's = doesn't > work as expected: They're described in bug#54034.) I'll see you there ;-) Stefan