all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Matthias Meulien <orontee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master b299c04201: Fix computation of outline heading level for non-git diff
Date: Sun, 20 Feb 2022 09:36:25 -0500	[thread overview]
Message-ID: <jwvpmnhtxrt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tucuklt2.fsf@gmail.com> (Matthias Meulien's message of "Sun, 20 Feb 2022 09:02:33 +0100")

Matthias Meulien [2022-02-20 09:02:33] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Ah, thanks.  I just pushed a patch which should fix it.
> Can you confirm that for the patch file I submitted, after your fix is
> applied, `diff--font-lock-prettify' is now supposed to do nothing?

Not quite.  My patch fixes the error that incorrectly moved the first
`+` and `-` of the file header to the fringe.  IOW the result is that on
non-Git diffs, `diff--font-lock-prettify` will still move the `+` and
`-` of the diffs into the fringe, but it will leave the rest (most
importantly the file headers) untouched.

> (Just in case 😉 there're other cases where prettifying diff's doesn't
> work as expected: They're described in bug#54034.)

I'll see you there ;-)


        Stefan




      reply	other threads:[~2022-02-20 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164503923630.1044.8899541087881650110@vcs2.savannah.gnu.org>
     [not found] ` <20220216192037.2F236C00894@vcs2.savannah.gnu.org>
2022-02-16 20:50   ` master b299c04201: Fix computation of outline heading level for non-git diff Stefan Monnier
2022-02-17  7:21     ` Matthias Meulien
2022-02-19 19:06       ` Stefan Monnier
2022-02-20  8:02         ` Matthias Meulien
2022-02-20 14:36           ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpmnhtxrt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.