From: Stefan Monnier <monnier@iro.umontreal.ca>
To: James N. V. Cash <james.nvc@gmail.com>
Cc: Juri Linkov <juri@linkov.net>, emacs-devel@gnu.org
Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers
Date: Fri, 29 Apr 2022 12:18:18 -0400 [thread overview]
Message-ID: <jwvpmkzrhkd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zgk42day.fsf@occasionallycogent.com> (James N. V. Cash's message of "Fri, 29 Apr 2022 10:07:33 -0400")
James N. V. Cash [2022-04-29 10:07:33] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> + (let ((beg (if (number-or-marker-p beg)
>>> + beg
>>> + (save-excursion
>>> + (goto-char (minibuffer-prompt-end))
>>> + (search-forward beg))))
>>> + (end (if (number-or-marker-p end)
>>> + end
>>> + (save-excursion
>>> + (goto-char (point-max))
>>> + (search-backward end)))))
>>
>> What if there are several matches for `beg` and/or for `end` in
>> the buffer? How do we know we got the intended one?
>
> A good question; as far as I can tell though, `beg` and `end` are only
> strings when called via `choose-completion` in `simple.el`, when it
> passes in `base-affixes`. `base-affixes` is in turn set to
> `completion-base-affixes`, which gets set in
> `minibuffer-completion-help`. There, the value that becomes `beg` is
> `(buffer-substring (minibuffer--completion-prompt-end) (+ start base-size))`
> and `end` is `(buffer-substring (point) (point-max))`, so I think that changing
> `minibuffer-prompt-end` in my patch to
> `minibuffer--completion-prompt-end` would suffice to ensure that it is
> always matching from the correct point to match the intended positions.
I think rather than (minibuffer--completion-prompt-end) and (point-max),
we should be using "the beginning of the completion area" and "the end
of the completion area". In a typical minibuffer completion, that's
exactly the same, but in `completing-read-multiple` or
`complete-in-region` the difference can be significant.
Stefan
next prev parent reply other threads:[~2022-04-29 16:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 0:36 [PATCH] Handle case where `beg` and `end` are strings instead of markers James N. V. Cash
2022-04-29 1:10 ` James N. V. Cash
2022-04-29 7:05 ` Juri Linkov
2022-04-29 12:10 ` James N. V. Cash
2022-04-29 12:55 ` Stefan Monnier
2022-04-29 14:07 ` James N. V. Cash
2022-04-29 16:18 ` Stefan Monnier [this message]
2022-04-29 17:20 ` James N. V. Cash
2022-04-29 17:29 ` Juri Linkov
2022-04-29 21:05 ` Stefan Monnier
2022-04-30 12:41 ` James N. V. Cash
2022-04-30 13:44 ` Stefan Monnier
2022-04-30 15:48 ` James N. V. Cash
2022-05-01 18:06 ` Juri Linkov
2022-05-02 15:32 ` James N. V. Cash
2022-05-02 19:11 ` Juri Linkov
2022-05-04 12:08 ` James N. V. Cash
2022-05-04 19:27 ` Juri Linkov
2022-05-04 21:09 ` James N. V. Cash
2022-05-05 18:16 ` Juri Linkov
2022-05-01 18:03 ` Juri Linkov
2022-05-01 18:37 ` Stefan Monnier
2022-05-05 18:19 ` Juri Linkov
2022-05-05 18:30 ` Exiting completion-in-region-mode (was: Handle case where `beg` and `end` are strings instead of markers) Juri Linkov
2022-05-19 18:52 ` Exiting completion-in-region-mode Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpmkzrhkd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=james.nvc@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.