From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding refactoring capabilities to Emacs Date: Thu, 07 Sep 2023 12:20:10 -0400 Message-ID: References: <83fs4f36wi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , "Philip K." , Dmitry Gutov , emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 07 18:21:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeHkm-0006Mk-4T for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Sep 2023 18:21:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeHjx-0001Ae-Oe; Thu, 07 Sep 2023 12:20:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeHjv-0001AH-JJ for emacs-devel@gnu.org; Thu, 07 Sep 2023 12:20:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeHjr-0001k4-Mo; Thu, 07 Sep 2023 12:20:19 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3F2B810006B; Thu, 7 Sep 2023 12:20:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694103612; bh=xRntIbfbpGxaF+WtcO1HQst2uqebaeEPY9ujc7vr5VE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CuezgumnEph4duVlesP9SVghXQMdokeD/UeZL86fJ9tlUnpkTT6bHYNbf7Y1ToB2k YBldffxMxHkxvJXdS7fs3R2Braa5Xw1w+P6PyuoNlRpfnDgOiHjUkK9g8InApHs032 S/A7fiDJFGYBpFmDqmCALHKG+S69pTSLV0LDOnBVvbnkK8UEGThxqjQrzVodBekgKX P0fEUQi0hkAZoczujiE2+MFzjZ0kgpQAa88tjMO8ncW0P2fa8/4c9Z0ualnDSMTQX3 hf2U64xo16R8A26HS424j/ng5B6+DrYLrvp8Zzaeti2w3mGYAXRy5SdE6dpdiMzpJ3 YORskCMZlbBRw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EC3E2100046; Thu, 7 Sep 2023 12:20:11 -0400 (EDT) Original-Received: from pastel (69-165-136-223.dsl.teksavvy.com [69.165.136.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BB8B21202A0; Thu, 7 Sep 2023 12:20:11 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Thu, 7 Sep 2023 15:39:49 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310265 Archived-At: > Also, it would be very good if we could have an early backend which is > *not* LSP. An obvious candidate is Elisp. I'd like to know what is > the minimal effort to write a lisp function based on the new > macroexpanding tricks that Stefan Monnier developed that says > precisely where a given symbol is used as a variable in a function. > As far as I understand, these techniques are currently being used for > accurate completion, but they could maybe be used for accurate > refactorings. Hmm... the `elisp--local-variables` functionality (beside the associated security issues and occasional errors) provides only a (somewhat) reliable list of variables that are in-scope. So it could potentially be extended to offer a way to jump to the declaration of a local variable from a reference to it, but it doesn't know how to find all (and only) the references to a given variable. We could extend it to a full code-walker that can distinguish between identifiers that refer to functions vs variables and which skips "data" and obeys scope, and thus collect reliably all the references. But `cconv-analyze-form` is probably a better starting point :-) Going back from there to the actual source code can be a fair bit more tricky, but Alan's symbols-with-positions should provide just what we need. > IMO diff is the lingua franca for communicating changes to source > code around the world, even in those pretty web interfaces that > you and many others like. So it makes full sense to support it > and to support it well. +1, tho I think the general framework should be agnostic to the specific way a change is presented to the user. >> - I would probably want to bind the originally proposed >> 'diff-apply-everything' to 'C-c C-c' (e.g. "commit the change to disk"), Agreed. >> but that's already taken in diff-mode. I don't think the current `C-c C-c` binding in `diff-mode` should get in the way. That command is available via different bindings already, and this is a specific use of diff-mode where `diff-apply-everything` makes a lot of sense (as opposed to `C-x v =` where the changes are usually already applied anyway so `diff-apply-everything` is rarely what we want). >> - 'git diff' has a less-frequently used option called '--word-diff' >> which could reduce the length of the diff in the case I am testing (but >> I guess diff-mode would have to be updated to support that output). And >> another way in that direction would be to reduce the size of the diff >> context (e.g. to 0). [ Side note: we could also extend diff-mode to do such "rewrite" inside Emacs. Hiding some of the context should be fairly easy, for example. Also I've often wished for `diff-refine-hunk` to try and interlace the lines so as to minimize the distance between the "before" and "after" lines. ] > But I wouldn't overthink UI details at this point in the game either. +1 Stefan