From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Date: Tue, 30 Jan 2024 17:57:39 -0500 Message-ID: References: <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org> <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> <871q9yonl8.fsf@localhost> <87jznqve8g.fsf@localhost> <878r46v5dp.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25836"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 30 23:58:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUx3p-0006Vp-5d for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jan 2024 23:58:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUx33-0006mw-Vp; Tue, 30 Jan 2024 17:57:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUx32-0006mi-Cr for emacs-devel@gnu.org; Tue, 30 Jan 2024 17:57:44 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUx30-0000nu-Oo for emacs-devel@gnu.org; Tue, 30 Jan 2024 17:57:44 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 358AA1000DA; Tue, 30 Jan 2024 17:57:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706655460; bh=d3SxKD3+HVtl+So+ff2HbTfHE19DiqJJzHddjh53ic0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FCtLda7AVW/7s7czvRR/ahl8DXAvz1zlXO+PgYD8jLWOY8SaGq9LA/2LRZ+LU/Ybt dKgPDcQBy+vAxSymdgMC3h950XkO9AP0tpFok9d44s6q2v1z88vXwQqq9VR0ppgK4u Z91NnU5p/muWfD1Fu5wyg9GvGxB+54vAqLWRqP8+5RjdlHOrviRJoWuPVA3EFV98+S Jp4aD5ccTDQWsVFw6T2uj2PRfufdfYHRkeVZ9b9dSZ2UTE7bPDelgPm2tYvAJV7h8I 6z42x1XlfFra7AkRIgzfkjtnCxhZy7pXvRXiDl1TO9IWTqzLEsGfgEtFS2rsj7qHdE 3BoEKUOt5HyQw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3A71B100054; Tue, 30 Jan 2024 17:57:40 -0500 (EST) Original-Received: from alfajor (104-222-119-131.cpe.teksavvy.com [104.222.119.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 164CE12032C; Tue, 30 Jan 2024 17:57:40 -0500 (EST) In-Reply-To: <878r46v5dp.fsf@localhost> (Ihor Radchenko's message of "Tue, 30 Jan 2024 22:11:14 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315645 Archived-At: Ihor Radchenko [2024-01-30 22:11:14] wrote: > Stefan Monnier writes: >>> I mean an opposite: if `declare-function' is called globally, but the >>> actual function is only called by a single function in the file, emit >>> warning. >> I see. Not sure it would be very useful: the issue is not "it's only >> used here" but "it's only *available* here" (because of the >> `require`). > Does it mean that you would not recommend moving declare-function inside > function if that function does not have require? The `declare-function` tells the compiler "trust me, this function will exist by the time we reach this point in the code". Often as a programmer, what makes me confident to say such a thing is that I just did a `require`, but not always. Other times it's because I'm within a function which is placed on a hook called by that other package, so even though I'm not explicitly loading that package, I know that *if* the function is run, then presumably the package is loaded. Other times it's because I'm within a conditional branch that corresponds to a particular version of Emacs (or some dependency) which tells me that that function should be defined. Yet other times, it's because I know the whole file will not be used/usable without such and such other package, yet I can't `require` that other package (e.g. because I don't want it as a hard dependency, or to avoid a circular dependency, ...). The pace where to put it depends on the specifics of the case. Stefan