From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords Date: Fri, 15 Mar 2024 09:29:18 -0400 Message-ID: References: <86wmq39av4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16926"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 15 14:30:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rl7dV-00048s-Pw for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Mar 2024 14:30:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rl7cl-00024Q-40; Fri, 15 Mar 2024 09:29:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl7cj-000247-BR for emacs-devel@gnu.org; Fri, 15 Mar 2024 09:29:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl7ch-0003uE-K3; Fri, 15 Mar 2024 09:29:25 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1041B10005D; Fri, 15 Mar 2024 09:29:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1710509360; bh=gsT1dvpnOC9LiFVt4TfRYU4nByVccn7ljKaerCFmfGc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Fq+SXjvulHgfLpdHVVJtrr2SLuaJdDC8fXVRSWlrMHPfkenIZv4P0HPT6MoBBhr5x MCWho9c0jSkstZKsBa8tkWev2lk9jJfQXs5TRPh8ycbjUPl9Vy32asvcN2BGpgI2Ez I5NYAeZqC/YWt7ntMTcxrAhSVTaUtQiArFL1C831jFLZiLpQAU01X/fSfTKNDS9ZkN 1utT5k9ZR4CUTDZyppx4lkwSBefhw0EbusmAZh4KwkZ+D0dAogptDsl5HG2SGHIFt7 JwbwtaCNJelolMy5j4L3SYWuxAlF5+z82aMjdqByAuIrUY25XYEHEChQcZtuy9UgBW 6n4LdHBp3DmGw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 215B8100048; Fri, 15 Mar 2024 09:29:20 -0400 (EDT) Original-Received: from pastel (unknown [216.154.27.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EF14A1207AC; Fri, 15 Mar 2024 09:29:19 -0400 (EDT) In-Reply-To: <86wmq39av4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Mar 2024 10:07:27 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317070 Archived-At: > The changes in the above commit cause the following warning when > compiling simple.el: > > In read-passwd-toggle-visibility: > simple.el:10880:18: Warning: reference to free variable `icon-preference' Does the patch below fix the problem? [ I remember seeing the warning a few days ago, but can't reproduce it right now. ] Maybe we should do something so `icons.el` is easier to use from preloaded files. Stefan diff --git a/lisp/simple.el b/lisp/simple.el index f127290231b..e0988f9dbd1 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -10870,6 +10932,8 @@ read-passwd-toggle-visibility "Toggle minibuffer contents visibility. Adapt also mode line." (interactive) + (require 'icons) ;; Will presumably already be loaded. + (defvar icon-preference) (setq read-passwd--hide-password (not read-passwd--hide-password)) (with-current-buffer read-passwd--mode-line-buffer (setq read-passwd--mode-line-icon