Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords

[Stefan Monnier <monnier@iro.umontreal.ca>]

> The changes in the above commit cause the following warning when
> compiling simple.el:
>
>   In read-passwd-toggle-visibility:
>   simple.el:10880:18: Warning: reference to free variable `icon-preference'

Does the patch below fix the problem?
[ I remember seeing the warning a few days ago, but can't reproduce it
  right now.  ]

Maybe we should do something so `icons.el` is easier to use
from preloaded files.


        Stefan


diff --git a/lisp/simple.el b/lisp/simple.el
index f127290231b..e0988f9dbd1 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -10870,6 +10932,8 @@ read-passwd-toggle-visibility
   "Toggle minibuffer contents visibility.
 Adapt also mode line."
   (interactive)
+  (require 'icons) ;; Will presumably already be loaded.
+  (defvar icon-preference)
   (setq read-passwd--hide-password (not read-passwd--hide-password))
   (with-current-buffer read-passwd--mode-line-buffer
     (setq read-passwd--mode-line-icon