* Re: [nongnu] elpa/scala-mode df60066e31 4/5: Require version 25.1
[not found] ` <20241227090039.5B112CED5C8@vcs3.savannah.gnu.org>
@ 2024-12-27 15:45 ` Stefan Monnier
0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2024-12-27 15:45 UTC (permalink / raw)
To: Heikki Vesalainen; +Cc: emacs-devel
> -;; Tested only for emacs 24
> -(unless (<= 24 emacs-major-version)
> +;; Tested only for emacs 25
> +(unless (<= 25 emacs-major-version)
> (error
> - (format "The Scala mode has been tested only on Emacs version 24.2 (and not your Emacs version %s.%s)"
> + (format "The Scala mode has been tested only on Emacs version 25.1 (and not your Emacs version %s.%s)"
> emacs-major-version emacs-minor-version)))
I think the test should not be for "it is known to work with your Emacs"
but "is it known *not* to work with your Emacs".
If you know you use a feature of Emacs-25 without which your code won't
work, then the test is right but the message is wrong.
Else, you might want to relax your test (and change the message), or
replace the `error` with a `message`.
Stefan
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-12-27 15:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <173529003822.999392.7161642544221156448@vcs3.savannah.gnu.org>
[not found] ` <20241227090039.5B112CED5C8@vcs3.savannah.gnu.org>
2024-12-27 15:45 ` [nongnu] elpa/scala-mode df60066e31 4/5: Require version 25.1 Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.