Re: [nongnu] elpa/scala-mode df60066e31 4/5: Require version 25.1

[Stefan Monnier <monnier@iro.umontreal.ca>]

> -;; Tested only for emacs 24
> -(unless (<= 24 emacs-major-version)
> +;; Tested only for emacs 25
> +(unless (<= 25 emacs-major-version)
>    (error
> -   (format "The Scala mode has been tested only on Emacs version 24.2 (and not your Emacs version %s.%s)"
> +   (format "The Scala mode has been tested only on Emacs version 25.1 (and not your Emacs version %s.%s)"
>             emacs-major-version  emacs-minor-version)))

I think the test should not be for "it is known to work with your Emacs"
but "is it known *not* to work with your Emacs".

If you know you use a feature of Emacs-25 without which your code won't
work, then the test is right but the message is wrong.
Else, you might want to relax your test (and change the message), or
replace the `error` with a `message`.


        Stefan