From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Richard Sharman <rsharman@pobox.com>
Cc: Juanma Barranquero <lekktu@gmail.com>,
Emacs Devel <emacs-devel@gnu.org>, Richard Stallman <rms@gnu.org>,
martin rudalics <rudalics@gmx.at>
Subject: Re: patch to hilight-chg not in emacs 22.1
Date: Wed, 19 Mar 2008 12:20:13 -0400 [thread overview]
Message-ID: <jwvod9awuv1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1DEEFF6E-3F47-47FE-82AC-AFFA68D3F7FF@pobox.com> (Richard Sharman's message of "Tue, 18 Mar 2008 22:43:53 -0400")
>> In what way are those problems different if the command is named
>> "highlight-changes-toggle-visibility" and implemented without
>> define-minor-mode?
> Yes, I agree it's the same thing in code. But I still think that people
> will find it confusing.
I'm pretty sure we can find a name that makes things clear.
E.g. rename highlight-changes-toggle-visibility to
highlight-changes-recording-only-mode (and reverse its meaning)?
> Originally, the highlight-change-mode function had the ability to also set
> active and passive states (when enabling the mode) and RMS thought it would
> be more consistent to have the function purely toggle the mode on or off.
> My reaction to having two related modes was that it would be confusing but
> I'm not really averse to it.
Make sure the docstring explains that one of the two minor-modes is
a sub-mode of the other.
Stefan
next prev parent reply other threads:[~2008-03-19 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 17:52 patch to hilight-chg not in emacs 22.1 Richard Sharman
2008-03-17 14:11 ` Stefan Monnier
2008-03-18 3:11 ` Richard Sharman
2008-03-18 16:51 ` Stefan Monnier
2008-03-19 2:43 ` Richard Sharman
2008-03-19 16:20 ` Stefan Monnier [this message]
2008-04-25 14:27 ` Juanma Barranquero
2008-05-02 3:21 ` Richard Sharman
2008-05-02 8:53 ` Juanma Barranquero
2008-03-18 9:55 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvod9awuv1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=rms@gnu.org \
--cc=rsharman@pobox.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.