From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Patch to trunk: merge common code in hourglass impl Date: Mon, 14 Jul 2008 21:41:16 -0400 Message-ID: References: <484660F1.2070609@gnu.org> <484709B0.9060804@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216086155 4586 80.91.229.12 (15 Jul 2008 01:42:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Jul 2008 01:42:35 +0000 (UTC) Cc: emacs- devel To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 15 03:43:23 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KIZZS-00061w-0A for ged-emacs-devel@m.gmane.org; Tue, 15 Jul 2008 03:43:14 +0200 Original-Received: from localhost ([127.0.0.1]:55733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KIZYY-0002So-Ij for ged-emacs-devel@m.gmane.org; Mon, 14 Jul 2008 21:42:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KIZXt-000221-EC for emacs-devel@gnu.org; Mon, 14 Jul 2008 21:41:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KIZXs-00020y-4K for emacs-devel@gnu.org; Mon, 14 Jul 2008 21:41:36 -0400 Original-Received: from [199.232.76.173] (port=34871 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KIZXr-00020l-Ru for emacs-devel@gnu.org; Mon, 14 Jul 2008 21:41:35 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:41125) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KIZXr-0003c5-7z for emacs-devel@gnu.org; Mon, 14 Jul 2008 21:41:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqM+AL+de0jO+IfCPGdsb2JhbACBWpBMAQEBAS0BmW2BaA X-IronPort-AV: E=Sophos;i="4.30,362,1212379200"; d="scan'208";a="24344771" Original-Received: from 206-248-135-194.dsl.teksavvy.com (HELO pastel.home) ([206.248.135.194]) by ironport2-out.teksavvy.com with ESMTP; 14 Jul 2008 21:41:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2B48D85AB; Mon, 14 Jul 2008 21:41:16 -0400 (EDT) In-Reply-To: (Adrian Robert's message of "Mon, 14 Jul 2008 20:46:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100711 Archived-At: > Re: http://thread.gmane.org/gmane.emacs.devel/98341 > I posted this patch last month, and although it does not help matters under > w32 and it was established it would not be easy to do this anytime soon, it > does allow the X, Carbon, and upcoming Cocoa ports to share non-GUI > hourglass logic code. Since there were no objections to the patch, and it > was tested under X (and will be soon under Cocoa), would it be OK to > commit it? > I am attaching a re-synced version of the patch, with a HAVE_WINDOW_SYSTEM > check added. Sounds good to me, Stefan