From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Reviewing changes Date: Fri, 21 Nov 2008 09:32:28 -0500 Message-ID: References: <87y6zggnmz.fsf@red-bean.com> <87d4grbcc0.fsf@red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227277980 30405 80.91.229.12 (21 Nov 2008 14:33:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2008 14:33:00 +0000 (UTC) Cc: kfogel@red-bean.com, cyd@stupidchicken.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 21 15:34:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L3X4x-0001Ld-IQ for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 15:33:51 +0100 Original-Received: from localhost ([127.0.0.1]:38091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3X3o-0005hK-Hl for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 09:32:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3X3j-0005eX-9u for emacs-devel@gnu.org; Fri, 21 Nov 2008 09:32:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3X3h-0005e1-S3 for emacs-devel@gnu.org; Fri, 21 Nov 2008 09:32:33 -0500 Original-Received: from [199.232.76.173] (port=58894 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3X3h-0005dy-MS for emacs-devel@gnu.org; Fri, 21 Nov 2008 09:32:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:39381) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L3X3e-00016p-JU; Fri, 21 Nov 2008 09:32:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqwEAPNUJklMCrcy/2dsb2JhbACBbNMfgnyBGw X-IronPort-AV: E=Sophos;i="4.33,644,1220241600"; d="scan'208";a="30140195" Original-Received: from 76-10-183-50.dsl.teksavvy.com (HELO pastel.home) ([76.10.183.50]) by ironport2-out.teksavvy.com with ESMTP; 21 Nov 2008 09:32:29 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 83FB980FF; Fri, 21 Nov 2008 09:32:28 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Fri, 21 Nov 2008 13:28:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105890 Archived-At: >> So you object to naming them "code reviews"? That's OK, let's call them >> "random comments", then. >> I just can't see how encouraging such random comments can hurt. > I didn't say it will hurt. I said it won't help us make the code > quality better, which I assumed what this was all about. Sounds like > my assumption was wrong. No, this was all about asking to change the format of the email sent to emacs-diffs and emacs-commit so that they'd contain both the changelog and the diffs (hopefully of all the files modified by the given commit) together. Karl mentioned he'd prefer it, and also added that it would make reviewing easier. Your argumentation seemed to say that you disagreed with such a change specifically because it would make people start to do such pseudo-reviewing which is worse than not doing reviewing at all. Stefan