From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 3224@debbugs.gnu.org
Subject: bug#3224: 23.0.92; vc-dir vs uniquify: wrong directory used
Date: Wed, 06 Jan 2010 00:38:07 -0500 [thread overview]
Message-ID: <jwvocl7hkkq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b1001052000k2e829152ob1362be6d4d63516@mail.gmail.com> (Juanma Barranquero's message of "Wed, 6 Jan 2010 05:00:38 +0100")
> --- lisp/uniquify.el 2010-01-04 05:35:18 +0000
> +++ lisp/uniquify.el 2010-01-06 03:22:51 +0000
> @@ -232,9 +232,9 @@
> ;; of code like in set-visited-file-name:
> ;; (or (string= new-name (buffer-name)) (rename-buffer new-name t))
> ;; So we need to refresh the dirname of the uniquify-item.
> - (setf (uniquify-item-dirname (car items))
> - (uniquify-buffer-file-name
> - (uniquify-item-buffer (car items))))
> + (let ((bfn (uniquify-buffer-file-name (uniquify-item-buffer (car
> items)))))
> + (when bfn
> + (setf (uniquify-item-dirname (car items)) bfn)))
That doesn't sound right.
Why is bfn nil in your case, and why should we not update
uniquify-item-dirname correspondingly?
> @@ -265,9 +265,11 @@
> list-buffers-directory))))
> (when filename
> (directory-file-name
> - (file-name-directory
> - (expand-file-name
> - (directory-file-name filename))))))))
> + (if (file-directory-p filename)
> + (file-name-as-directory filename)
> + (file-name-directory
> + (expand-file-name
> + (directory-file-name filename)))))))))
I don't thing that's right. Instead, you probably want to set
list-buffers-directory to something like (expand-file-name "*vc-dir*"),
as is done in PCL-CVS.
Stefan
next prev parent reply other threads:[~2010-01-06 5:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b1001071940k28f0f35y508b7f1c26640f9f@mail.gmail.com>
2009-05-05 15:19 ` bug#3224: 23.0.92; vc-dir vs uniquify: wrong directory used Magnus Henoch
2009-08-04 12:30 ` Dan Nicolaescu
2010-01-06 4:00 ` Juanma Barranquero
2010-01-06 4:55 ` Dan Nicolaescu
2010-01-06 5:38 ` Stefan Monnier [this message]
2010-01-06 10:17 ` Juanma Barranquero
2010-01-06 14:28 ` Stefan Monnier
2010-01-07 11:14 ` Juanma Barranquero
2010-01-07 14:54 ` Stefan Monnier
2010-01-07 15:09 ` Juanma Barranquero
2010-01-07 19:53 ` Stefan Monnier
2010-01-07 23:05 ` Juanma Barranquero
2010-01-08 3:22 ` Stefan Monnier
2010-01-07 15:10 ` Dan Nicolaescu
2010-01-07 15:19 ` Juanma Barranquero
2010-01-07 19:57 ` Stefan Monnier
2010-01-08 3:41 ` bug#3224: marked as done (23.0.92; vc-dir vs uniquify: wrong directory used) Emacs bug Tracking System
2009-09-24 20:53 ` bug#4553: 23.1; uniquify gives *vc-dir* buffer the wrong name Tom Tromey
2009-09-24 21:32 ` Dan Nicolaescu
2009-09-24 21:40 ` Processed: " Emacs bug Tracking System
2010-01-08 3:41 ` bug#4553: marked as done (23.1; uniquify gives *vc-dir* buffer the wrong name) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvocl7hkkq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3224@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.