* bug#5456: vc-hg-state does not search hg in vc-path
@ 2010-01-22 22:05 Stephan Bergmann
2010-01-25 6:16 ` Dan Nicolaescu
0 siblings, 1 reply; 3+ messages in thread
From: Stephan Bergmann @ 2010-01-22 22:05 UTC (permalink / raw)
To: 5456
At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path). What fixed it for me (on recent trunk) is
---8<---
=== modified file 'lisp/vc-hg.el'
--- lisp/vc-hg.el 2010-01-13 08:35:10 +0000
+++ lisp/vc-hg.el 2010-01-22 21:46:14 +0000
@@ -169,7 +169,8 @@
;; Ignore all errors.
(let ((process-environment
;; Avoid localization of messages so we can parse the output.
- (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)))
+ (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))
+ (exec-path (append vc-path exec-path)))
(process-file
"hg" nil t nil
@@ -205,7 +206,8 @@
(let ((process-environment
;; Avoid localization of messages so we can parse the output.
(append (list "TERM=dumb" "LANGUAGE=C" "HGRC=")
- process-environment)))
+ process-environment))
+ (exec-path (append vc-path exec-path)))
;; Ignore all errors.
(process-file
"hg" nil t nil
---8<---
-Stephan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#5456: vc-hg-state does not search hg in vc-path
2010-01-22 22:05 bug#5456: vc-hg-state does not search hg in vc-path Stephan Bergmann
@ 2010-01-25 6:16 ` Dan Nicolaescu
2010-01-25 15:35 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2010-01-25 6:16 UTC (permalink / raw)
To: Stephan Bergmann; +Cc: 5456
Stephan Bergmann <Stephan.Bergmann@Sun.COM> writes:
> At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path). What fixed it for me (on recent trunk) is
> ---8<---
> === modified file 'lisp/vc-hg.el'
> --- lisp/vc-hg.el 2010-01-13 08:35:10 +0000
> +++ lisp/vc-hg.el 2010-01-22 21:46:14 +0000
> @@ -169,7 +169,8 @@
> ;; Ignore all errors.
> (let ((process-environment
> ;; Avoid localization of messages so we can parse the output.
> - (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)))
> + (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))
> + (exec-path (append vc-path exec-path)))
>
> (process-file
> "hg" nil t nil
> @@ -205,7 +206,8 @@
> (let ((process-environment
> ;; Avoid localization of messages so we can parse the output.
> (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=")
> - process-environment)))
> + process-environment))
> + (exec-path (append vc-path exec-path)))
> ;; Ignore all errors.
> (process-file
> "hg" nil t nil
There's more places where a change like this would be necessary....
Actually, looking over all the VC backends, almost all could use vc-path,
but NONE does.
So I'd rather vote for deprecating vc-path in 23.2 and remove it later.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#5456: vc-hg-state does not search hg in vc-path
2010-01-25 6:16 ` Dan Nicolaescu
@ 2010-01-25 15:35 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2010-01-25 15:35 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: Stephan Bergmann, 5456
> So I'd rather vote for deprecating vc-path in 23.2 and remove it later.
Agreed, I see no need to treat VC specially in this regard (IIUC this
was done originally because RCS and SCCS started as a bunch of separate
commands with potentially conflicting names (like ci/co/...), and were
often installed in a non-standard place, but it doesn't seem relevant
nowadays).
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-25 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-22 22:05 bug#5456: vc-hg-state does not search hg in vc-path Stephan Bergmann
2010-01-25 6:16 ` Dan Nicolaescu
2010-01-25 15:35 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.