From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Refreshing Info nodes Date: Mon, 14 Jun 2010 20:42:18 -0400 Message-ID: References: <87631mkeic.fsf@gmail.com> <87hbl54oi0.fsf@mail.jurta.org> <871vc9ffdl.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276562643 6231 80.91.229.12 (15 Jun 2010 00:44:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 Jun 2010 00:44:03 +0000 (UTC) Cc: emacs-devel@gnu.org, Wojciech Meyer , Deniz Dogan To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 15 02:44:01 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OOKFA-00047s-1d for ged-emacs-devel@m.gmane.org; Tue, 15 Jun 2010 02:43:56 +0200 Original-Received: from localhost ([127.0.0.1]:43004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOKF7-0004Cp-Eg for ged-emacs-devel@m.gmane.org; Mon, 14 Jun 2010 20:43:05 -0400 Original-Received: from [140.186.70.92] (port=59377 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOKEn-00046u-Ra for emacs-devel@gnu.org; Mon, 14 Jun 2010 20:42:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOKEO-0008NW-FJ for emacs-devel@gnu.org; Mon, 14 Jun 2010 20:42:21 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:44055 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOKEO-0008NM-B5 for emacs-devel@gnu.org; Mon, 14 Jun 2010 20:42:20 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAHNpFkxFxLbh/2dsb2JhbACebnLAMYUaBI0H X-IronPort-AV: E=Sophos;i="4.53,417,1272859200"; d="scan'208";a="68044567" Original-Received: from 69-196-182-225.dsl.teksavvy.com (HELO alfajor.home) ([69.196.182.225]) by ironport2-out.pppoe.ca with ESMTP; 14 Jun 2010 20:42:19 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id 6B71BAE251; Mon, 14 Jun 2010 20:42:18 -0400 (EDT) In-Reply-To: <871vc9ffdl.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 15 Jun 2010 00:57:50 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125937 Archived-At: > Perhaps a `(eq major-mode 'Info-mode)' check should be added > before `(pop-to-buffer "*info*")' in `Info-revert-find-node' > like in other Info commands. I'd rather check something more directly and explicitly related to reverting that just (derived-mode-p 'Info-mode). Ideally there should be no check: the code that does the pop-to-buffer should simply not be used at all when reverting, instead the non-reverting case should create a *info* buffer, setup the few needed vars and then trigger `revert-buffer' to do the actual work. Stefan