From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ns-win.el Date: Tue, 26 Oct 2010 11:27:33 -0400 Message-ID: References: <19651.37838.815906.240014@fencepost.gnu.org> <7seibdzmke.fsf@fencepost.gnu.org> <6B12217D-6FF2-42FE-A53C-AAA32C7AC510@gmail.com> <6geibdtpty.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288106878 20163 80.91.229.12 (26 Oct 2010 15:27:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Oct 2010 15:27:58 +0000 (UTC) Cc: emacs-devel@gnu.org, Dan Nicolaescu To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 26 17:27:55 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PAlRG-0005qz-VV for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2010 17:27:51 +0200 Original-Received: from localhost ([127.0.0.1]:48437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAlRG-0006RX-73 for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2010 11:27:50 -0400 Original-Received: from [140.186.70.92] (port=57731 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAlR8-0006Px-F6 for emacs-devel@gnu.org; Tue, 26 Oct 2010 11:27:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAlR7-00041r-Hk for emacs-devel@gnu.org; Tue, 26 Oct 2010 11:27:42 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAlR6-00041O-6J; Tue, 26 Oct 2010 11:27:40 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o9QFRaTR007571; Tue, 26 Oct 2010 11:27:36 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 4224AB4681; Tue, 26 Oct 2010 11:27:35 -0400 (EDT) In-Reply-To: (Adrian Robert's message of "Tue, 26 Oct 2010 13:49:36 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3659=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132132 Archived-At: >>> On the other hand, they were moved from menu-bar.el TO ns-win.el >>> during the merge. It was desired to keep these platform-specific >>> things in the platform-specific file rather than cluttering up >>> common files, and I've come to agree myself this is the best way. I can't remember why we moved these menu-bar thingies to ns-win.el, but I think they're nicer where they are now: these differences are things we want to stick out like sore-thumbs to remind us of the inconsistencies. > I don't feel strongly, but having it in ns-win.el makes it clearer > what is done differently for that platform and keeps the clutter out > for people reading the common code. The code isn't that much "work" > and it's limited to when the NS windowing system is actually used. > Does it really need to be in DOC file for all builds, or just builds > that include NS? Yes, we want to have a single DOC file, identical for all cases. >>> They are minor, but make a significant difference in making the >>> menus seem less alien on the platform. On the other hand anything >>> less minor would deviate too much from the common emacs UI and >>> confuse users coming from other platforms. They are a compromise, >>> but a reasonable one. I think it's usually good to have Emacs follow the platform guidelines. It's also good to have Emacs be consistent across platforms. So there's sometimes a tension here. Moving the Spell menu seems like a good decision in this case. Maybe we could even resolve this difference by moving the Spell menu for all the platforms (this is a very weak suggestion: I rarely if ever use the menus, so I have no idea what would be a good change in this respect). Stefan