all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: emacs-devel@gnu.org, Dan Nicolaescu <dann@gnu.org>
Subject: Re: ns-win.el
Date: Tue, 26 Oct 2010 11:27:33 -0400	[thread overview]
Message-ID: <jwvocahq8ql.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <FE67F68A-F8DF-438C-AEBA-17ADEB5DB154@gmail.com> (Adrian Robert's message of "Tue, 26 Oct 2010 13:49:36 +0300")

>>> On the other hand, they were moved from menu-bar.el TO ns-win.el
>>> during the merge. It was desired to keep these platform-specific
>>> things in the platform-specific file rather than cluttering up
>>> common files, and I've come to agree myself this is the best way.

I can't remember why we moved these menu-bar thingies to ns-win.el, but
I think they're nicer where they are now: these differences are things
we want to stick out like sore-thumbs to remind us of the inconsistencies.

> I don't feel strongly, but having it in ns-win.el makes it clearer
> what is done differently for that platform and keeps the clutter out
> for people reading the common code.  The code isn't that much "work"
> and it's limited to when the NS windowing system is actually used.
> Does it really need to be in DOC file for all builds, or just builds
> that include NS?

Yes, we want to have a single DOC file, identical for all cases.

>>> They are minor, but make a significant difference in making the
>>> menus seem less alien on the platform. On the other hand anything
>>> less minor would deviate too much from the common emacs UI and
>>> confuse users coming from other platforms. They are a compromise,
>>> but a reasonable one.

I think it's usually good to have Emacs follow the platform guidelines.
It's also good to have Emacs be consistent across platforms.  So there's
sometimes a tension here.  Moving the Spell menu seems like a good
decision in this case.  Maybe we could even resolve this difference by
moving the Spell menu for all the platforms (this is a very weak
suggestion: I rarely if ever use the menus, so I have no idea what would
be a good change in this respect).


        Stefan



  reply	other threads:[~2010-10-26 15:27 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1P9lT2-0005WD-37@internal.in.savannah.gnu.org>
     [not found] ` <jwvmxq4pez1.fsf-monnier+emacs@gnu.org>
2010-10-24  2:02   ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Glenn Morris
2010-10-24  5:08     ` Dan Nicolaescu
2010-10-24 19:45       ` Glenn Morris
2010-10-25 13:25         ` Adrian Robert
2010-10-25 14:51           ` Dan Nicolaescu
2010-10-26  2:59             ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-26  4:25               ` ns-win.el Glenn Morris
2010-10-26  4:54                 ` ns-win.el CHENG Gao
2010-10-26  5:10                 ` ns-win.el Adrian Robert
2010-10-26 15:18                 ` ns-win.el Stefan Monnier
2010-10-26  5:07               ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Adrian Robert
2010-10-26  6:45                 ` ns-win.el Glenn Morris
2010-10-26  7:47                   ` ns-win.el Eli Zaretskii
2010-10-26 10:49                   ` ns-win.el Adrian Robert
2010-10-26 15:27                     ` Stefan Monnier [this message]
2010-10-26 19:25                       ` ns-win.el Glenn Morris
2010-10-26 19:57                         ` ns-win.el Adrian Robert
2010-10-26  6:50                 ` ns-win.el Glenn Morris
2010-10-26  7:49                   ` ns-win.el Eli Zaretskii
2010-10-26 13:08                     ` ns-win.el Ted Zlatanov
2010-10-26 14:42                       ` ns-win.el Eli Zaretskii
2010-10-26 17:35                         ` ns-win.el Ted Zlatanov
2010-10-26  7:32                 ` ns-win.el Daniel Pittman
2010-10-24  7:55     ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Eli Zaretskii
2010-10-24 19:47       ` Glenn Morris
2010-10-25  0:54         ` Stefan Monnier
2010-10-25  4:56           ` Glenn Morris
2010-10-25  8:03             ` Stephen J. Turnbull
2010-10-25  9:28               ` Eli Zaretskii
2010-10-25  8:20             ` Eli Zaretskii
2010-10-28  3:54           ` moving x-select* [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-28  4:06             ` Eli Zaretskii
2010-10-28  5:32               ` Jason Rumney
2010-10-28  6:40                 ` Chad Brown
2010-10-28 13:54                   ` moving x-select* Jason Rumney
2010-10-28 15:28                     ` Chad Brown
2010-10-28 14:23             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvocahq8ql.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=adrian.b.robert@gmail.com \
    --cc=dann@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.