From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: New function: vc-ediff Date: Sat, 19 Mar 2011 22:45:10 -0400 Message-ID: References: <4D785193.3030201@gmail.com> <4D79A736.6080707@gmail.com> <831v2cu40y.fsf@gnu.org> <838vwkrroz.fsf@gnu.org> <86r5a3j1a1.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1300589311 6984 80.91.229.12 (20 Mar 2011 02:48:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2011 02:48:31 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Christoph Scholtes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 03:48:26 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q18gs-0006mR-Gg for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2011 03:48:26 +0100 Original-Received: from localhost ([127.0.0.1]:35274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q18dr-0000E8-7u for ged-emacs-devel@m.gmane.org; Sat, 19 Mar 2011 22:45:19 -0400 Original-Received: from [140.186.70.92] (port=38476 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q18dl-0000BQ-SB for emacs-devel@gnu.org; Sat, 19 Mar 2011 22:45:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q18dk-0003Px-MD for emacs-devel@gnu.org; Sat, 19 Mar 2011 22:45:13 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:8237 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q18dj-0003Pj-Ks; Sat, 19 Mar 2011 22:45:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAJMGhU1Ld/X5/2dsb2JhbACldHjBJoVjBJVp X-IronPort-AV: E=Sophos;i="4.63,213,1299474000"; d="scan'208";a="97263201" Original-Received: from 75-119-245-249.dsl.teksavvy.com (HELO pastel.home) ([75.119.245.249]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 19 Mar 2011 22:45:10 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ABBE55914C; Sat, 19 Mar 2011 22:45:10 -0400 (EDT) In-Reply-To: <86r5a3j1a1.fsf@gmail.com> (Christoph Scholtes's message of "Fri, 18 Mar 2011 20:24:06 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137439 Archived-At: >>>> You should be able to see the (e)diff for any version controlled file >>>> (for backends supported by VC), using vc-dir. >>> What, you mean I cannot see the diffs against a previous version of a >>> file unless I run vc-dir on its directory? >> I don't even know if it can. It's not relevant to the question at hand: >> there is no diff-revisions, there's only vc-diff; so if vc-diff is >> sufficient then so is vc-ediff. > So, what's the verdict on this issue? Is it acceptable the way it was > originally proposed or should I try to implement vc-ediff as a > replacement for ediff-revision? As long as it works (UI-wise) similarly to vc-diff, the behavior is fine. I wanted the implementation to rely as much as possible on VC and as little as possible on ediff's own revision control code, but that is not crucial, if doing it differently lets it share more code with ediff-revision. Can you submit a patch according to these guidelines? Stefan