From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ERC tracking broken Date: Tue, 29 Mar 2011 17:20:22 -0400 Message-ID: References: <8739m54zz7.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301434049 3876 80.91.229.12 (29 Mar 2011 21:27:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2011 21:27:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Antoine Levitt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 29 23:27:21 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4gRb-0008IW-6N for ged-emacs-devel@m.gmane.org; Tue, 29 Mar 2011 23:27:19 +0200 Original-Received: from localhost ([127.0.0.1]:53032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4gLC-0000pe-JH for ged-emacs-devel@m.gmane.org; Tue, 29 Mar 2011 17:20:42 -0400 Original-Received: from [140.186.70.92] (port=43573 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4gL7-0000pO-CD for emacs-devel@gnu.org; Tue, 29 Mar 2011 17:20:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4gL5-0002ps-SR for emacs-devel@gnu.org; Tue, 29 Mar 2011 17:20:36 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:37576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4gL5-0002pj-Jg for emacs-devel@gnu.org; Tue, 29 Mar 2011 17:20:35 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p2TLKNK0028517; Tue, 29 Mar 2011 17:20:23 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id EC88FB4465; Tue, 29 Mar 2011 17:20:22 -0400 (EDT) In-Reply-To: <8739m54zz7.fsf@gmail.com> (Antoine Levitt's message of "Tue, 29 Mar 2011 19:07:52 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3811=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3811> : streams <614767> : uri <838198> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137876 Archived-At: > ERC tracking seems to be broken. Reverting to the binary of emacs I > compiled yesterday fixes it, so I strongly suspect it's a result of > commit 5e4cb836580a8ef2f9ea9b4b8317005941920027 > Author: Stefan Monnier > Date: Mon Mar 28 16:26:35 2011 -0400 > Don't reset post-command-hook to nil upon error. > which interferes with a patch by Julien Danjou about using > post-command-hook to notice window changes in erc-track. I don't > remember the specifics though. My change should not affect the behavior of post-command-hook expect when one of the hook functions signals an error (something that should not happen, normally), so if it's due to my change, it's a bug in my change. Do you have a recipe to reproduce the problem, starting from "emacs -Q" (including for someone like me who basically never used IRC)? Stefan