From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] rcirc: support TLS/SSL and arbitrary connection method Date: Mon, 30 May 2011 22:24:53 -0300 Message-ID: References: <87fwnvvp3d.fsf@universe.krase.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306842593 17140 80.91.229.12 (31 May 2011 11:49:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 May 2011 11:49:53 +0000 (UTC) Cc: rcyeske@gmail.com, emacs-devel@gnu.org To: Marco Pessotto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 31 13:49:49 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QRNSH-00074R-ET for ged-emacs-devel@m.gmane.org; Tue, 31 May 2011 13:49:49 +0200 Original-Received: from localhost ([::1]:59115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRNSH-0003Re-35 for ged-emacs-devel@m.gmane.org; Tue, 31 May 2011 07:49:49 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRNS1-0002zF-6L for emacs-devel@gnu.org; Tue, 31 May 2011 07:49:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRNRx-0000CM-AH for emacs-devel@gnu.org; Tue, 31 May 2011 07:49:33 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRNRx-0000CI-6T for emacs-devel@gnu.org; Tue, 31 May 2011 07:49:29 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p4VBnLEL005851; Tue, 31 May 2011 07:49:23 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 02D18661D3; Mon, 30 May 2011 22:24:54 -0300 (ART) In-Reply-To: <87fwnvvp3d.fsf@universe.krase.net> (Marco Pessotto's message of "Mon, 30 May 2011 23:46:30 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3873=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3873> : streams <642603> : uri <884221> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139960 Archived-At: > I'm writing you to submit a patch for rcirc.el to give it support for > SSL connections. Thank you. But I'm afraid you're just a few weeks late: revno: 104199 committer: Stefan Monnier branch nick: trunk timestamp: Wed 2011-05-11 23:25:58 -0300 message: * lisp/net/rcirc.el: Add support for SSL/TLS connections. (rcirc-server-alist): New field `encryption'. (rcirc): Check `encryption' settings. (rcirc-connect): New arg `encryption'. Use open-network-stream. Merge make-local-variable into `set'. (rcirc--connection-open-p): New function. (rcirc-send-string, rcirc-clean-up-buffer): Use it to handle case where the process is not a network process (e.g. running gnutls-cli). (set-rcirc-decode-coding-system, set-rcirc-encode-coding-system): Make rcirc-(en|de)code-coding-system local here. (rcirc-mode): Merge make-local-variable into `set'. (rcirc-parent-buffer): Make permanent buffer-local. (rcirc-multiline-minor-mode): Don't do it here. (rcirc-switch-to-server-buffer): Don't switch to a random buffer if there's no server buffer. > The last 2 chunks of the patch are meant to strip the IRC colors. > Not really part of the "connection" patch, but IMHO useful. Could you describe a bit more what this is about (I'm not a regular IRC user)? I can't remember seeing those C-c escape sequences, when do they appear, what are they expected to do? Should we really strip them, or would it be even better to turn them into faces? > In case you're interested, I signed the Emacs papers some years ago. If you could send a new patch based on the latest code to provide the remaining features, I'd be happy to install it. Stefan