From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 12169@debbugs.gnu.org
Subject: bug#12169: [PATCH] Merge changes from upstream ruby-mode
Date: Fri, 10 Aug 2012 16:28:17 -0400 [thread overview]
Message-ID: <jwvobmicxew.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <50245771.6060109@yandex.ru> (Dmitry Gutov's message of "Fri, 10 Aug 2012 04:36:01 +0400")
> The change to `ruby-syntax-propertize-function' is kind of messy, but
> I don't see how to do it better without seriously rewriting
> ruby-syntax-propertize-heredoc'.
I think it can be simplified by adding a "\\(\\_<class\\s-*\\)?" pattern to
the here-doc regexp, but that only works for forward searches (which is
what is used in ruby-syntax-propertize but not in the
font-lock-syntactic-keywords code). So it's probably fine as it is.
I've installed your patch, but please fix the ChangeLog authorship as
pointed out by Glenn (just include the changes in a subsequent patch).
> Here's part 2, in which I'm skipping the next 3 commits:
> https://github.com/ruby/ruby/commit/85df40e9ab4559cd4ddde3f106ab56c76a808cc8
> https://github.com/ruby/ruby/commit/6b0dc7fd81b25bc66681548b8b82f38258f7e08c
> https://github.com/ruby/ruby/commit/862048e28d26112af1e67205cfd1c16564590bce
I also added that patch. I presume that you're also trying to convince
Ruby's maintainers to undo those changes?
Same as before: please provide a subsequent patch which corrects the
authorship attribution.
Stefan
next prev parent reply other threads:[~2012-08-10 20:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 0:36 bug#12169: [PATCH] Merge changes from upstream ruby-mode Dmitry Gutov
[not found] ` <handler.12169.B.13445594689259.ack@debbugs.gnu.org>
2012-08-10 14:52 ` bug#12169: Acknowledgement ([PATCH] Merge changes from upstream ruby-mode) Dmitry Gutov
2012-08-10 15:54 ` bug#12169: [PATCH] Merge changes from upstream ruby-mode Glenn Morris
2012-08-10 20:28 ` Stefan Monnier [this message]
2012-08-10 22:15 ` Dmitry Gutov
2012-08-10 23:06 ` Dmitry Gutov
2012-08-12 22:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvobmicxew.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12169@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.