From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 6799@debbugs.gnu.org
Cc: Michael Heerdegen <michael_heerdegen@web.de>
Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch]
Date: Sun, 16 Dec 2012 17:31:39 -0500 [thread overview]
Message-ID: <jwvobht7i02.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k3sj6juj@ch.ristopher.com> (Christopher Schmidt's message of "Sat, 15 Dec 2012 22:17:33 +0000 (GMT)")
> (save-restriction
> (widen)
Please add a comment explaining why widening should be used here.
> do (let ((buffer-read-only))
> (put-text-property (point) end
> 'invisible my-dired-hide-details-mode))
Better bind inhibit-read-only to t. Or better yet, use
with-silent-modifications (but move it outside the loop).
Also, rather than set the invisible property to nil or t, better set it
to another symbol (e.g. `dired-details'), whose meaning is then
controlled by add-to-invisibility-spec.
> (defadvice dired-insert-set-properties
> (after my-add-hide-props (beg end) activate)
Obviously, this would have to be turned into a patch, and since it's not
small, it would need to be moved to its own function (which would be
called from dired-insert-set-properties).
> (defadvice find-dired (after my-fix-move-process-mark-to-arg activate)
> (move-marker (process-mark (get-buffer-process (current-buffer)))
> (save-excursion
> (goto-char (point-min))
> (forward-line 1)
> (point))))
How is that related to dired-details?
Stefan
next prev parent reply other threads:[~2012-12-16 22:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 14:20 bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Drew Adams
2011-01-28 23:08 ` Drew Adams
2011-03-13 3:28 ` Juanma Barranquero
2011-03-13 16:58 ` Drew Adams
2012-04-12 19:10 ` Lars Magne Ingebrigtsen
2012-04-12 20:05 ` Drew Adams
2012-04-25 15:46 ` Rob Giardina
2012-07-21 20:12 ` Drew Adams
2012-12-15 21:15 ` Christopher Schmidt
2012-12-15 22:17 ` Christopher Schmidt
2012-12-16 22:31 ` Stefan Monnier [this message]
2012-12-17 13:24 ` Christopher Schmidt
2013-02-10 15:02 ` Christopher Schmidt
2013-02-10 15:08 ` Christopher Schmidt
2013-02-11 3:37 ` Stefan Monnier
2013-02-11 8:19 ` Christopher Schmidt
2013-02-11 14:25 ` Stefan Monnier
2013-02-11 16:08 ` Christopher Schmidt
2013-02-11 17:58 ` Stefan Monnier
2013-02-11 18:07 ` Drew Adams
2013-02-11 19:52 ` Christopher Schmidt
2013-02-13 9:54 ` Christopher Schmidt
2013-02-15 15:25 ` Stefan Monnier
2013-02-15 18:44 ` Christopher Schmidt
2013-02-16 21:52 ` Juri Linkov
2013-02-16 22:58 ` Drew Adams
2013-02-17 10:05 ` Juri Linkov
2013-02-17 14:57 ` Christopher Schmidt
2013-02-18 9:49 ` Juri Linkov
2013-02-18 14:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvobht7i02.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6799@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.