Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify.

Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify.

[Stefan Monnier]

>  (defun desktop-list* (&rest args)
> -  (if (null (cdr args))
> -      (car args)
> -    (setq args (nreverse args))
> -    (let ((value (cons (nth 1 args) (car args))))
> -      (setq args (cdr (cdr args)))
> -      (while args
> -	(setq value (cons (car args) value))
> -	(setq args (cdr args)))
> -      value)))
> +  (and args (cl-list* args)))
 
Doesn't look right.  Shouldn't it be

   (and args (apply #'cl-list* args))

or more simply

   (apply #'cl-list* args)

which boils down to

   (defalias 'desktop-list* 'cl-list*)


-- Stefan

Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify.

[Stephen J. Turnbull]

Stefan Monnier writes:

 >    (defalias 'desktop-list* 'cl-list*)

Try `(cl-list*)'.

Everybody-wants-to-be-Andreas-ly y'rs,

Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify.

[Juanma Barranquero]

On Tue, Jul 23, 2013 at 3:25 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:

> Doesn't look right.  Shouldn't it be
>
>    (and args (apply #'cl-list* args))

Yes, sorry. Brain fart.

> or more simply
>
>    (apply #'cl-list* args)
>
> which boils down to
>
>    (defalias 'desktop-list* 'cl-list*)

Not exactly:

(desktop-list*)  => nil    ; with the old definition
(cl-list*)  => *** Eval error ***  Wrong number of arguments: (1 . &rest), 0

That's why I added (and arg ...)

Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify.

[Stefan Monnier]

> Not exactly:

> (desktop-list*)  => nil    ; with the old definition
> (cl-list*)  => *** Eval error ***  Wrong number of arguments: (1 . &rest), 0

Ah, good point, thanks,


        Stefan