Getting last-command with arguments

Getting last-command with arguments

[Suvayu Ali]

Hi,

I am conditionally repeating the last command from inside an elisp
function.  So I look at `last-command' and decide.  But now I want to
see the original arguments: say the command was, M-2 M-x my-command RET,
then I want to know 2 was passed to `my-command'.  I am not sure how I
can do that.

I looked in (info "(elisp) Command Loop Info"), unless I missed
something I didn't find anything about retrieving arguments.

Any ideas?

-- 
Suvayu

Open source is the future. It sets us free.

Re: Getting last-command with arguments

[Nicolas Richard]

Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:
> I am conditionally repeating the last command from inside an elisp
> function.  So I look at `last-command' and decide.  But now I want to
> see the original arguments: say the command was, M-2 M-x my-command RET,
> then I want to know 2 was passed to `my-command'.  I am not sure how I
> can do that.

The variable current-prefix-arg has that information.

hth,

-- 
Nicolas.

Re: Getting last-command with arguments

[Stefan Monnier]

>> I am conditionally repeating the last command from inside an elisp
>> function.  So I look at `last-command' and decide.  But now I want to
>> see the original arguments: say the command was, M-2 M-x my-command RET,
>> then I want to know 2 was passed to `my-command'.  I am not sure how I
>> can do that.
> The variable current-prefix-arg has that information.

Since we're talking about my-command rather than some random command,
you can simply change my-command to stash its argument in, say,
my-command--last-args.


        Stefan

Re: Getting last-command with arguments

[Suvayu Ali]

On Fri, Sep 13, 2013 at 08:42:37AM -0400, Stefan Monnier wrote:
> >> I am conditionally repeating the last command from inside an elisp
> >> function.  So I look at `last-command' and decide.  But now I want to
> >> see the original arguments: say the command was, M-2 M-x my-command RET,
> >> then I want to know 2 was passed to `my-command'.  I am not sure how I
> >> can do that.
> > The variable current-prefix-arg has that information.
> 
> Since we're talking about my-command rather than some random command,
> you can simply change my-command to stash its argument in, say,
> my-command--last-args.

Ah!  Did not think about that.  Thank you.

-- 
Suvayu

Open source is the future. It sets us free.

Re: Getting last-command with arguments

[Suvayu Ali]

Hi Nicolas,

On Fri, Sep 13, 2013 at 01:34:04PM +0200, Nicolas Richard wrote:
> Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:
> > I am conditionally repeating the last command from inside an elisp
> > function.  So I look at `last-command' and decide.  But now I want to
> > see the original arguments: say the command was, M-2 M-x my-command RET,
> > then I want to know 2 was passed to `my-command'.  I am not sure how I
> > can do that.
> 
> The variable current-prefix-arg has that information.

Thanks a lot.  But did you mean last-prefix-arg instead?  I want the
prefix arg that was passed to last-command.  After your hint, I read
(info "(elisp) Prefix Command Arguments").

This is pseudo-code for what I'm trying to do:

(defun my-cmd-1 (&optional args) nil)

(defun my-cmd-2 (&optional args) 
  (if (eq last-command 'my-cmd-1)
      (progn
	(setq this-command 'my-cmd-1)
	(my-cmd-1 last-prefix-arg)
	(setq prefix-arg last-prefix-arg))  ;; <-- this bit doesn't seem to work
    (some-command arg)))

Then I call my-cmd-1, now if I call my-cmd-2 right after, it repeats
my-cmd-1.  If I do something else in between, the my-cmd-2 just calls
some-command.

I hope my intentions are clearer now.

Cheers,

-- 
Suvayu

Open source is the future. It sets us free.

Re: Getting last-command with arguments

[Nicolas Richard]

Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:

> Hi Nicolas,
>
> On Fri, Sep 13, 2013 at 01:34:04PM +0200, Nicolas Richard wrote:
>> Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:
>> > I am conditionally repeating the last command from inside an elisp
>> > function.  So I look at `last-command' and decide.  But now I want to
>> > see the original arguments: say the command was, M-2 M-x my-command RET,
>> > then I want to know 2 was passed to `my-command'.  I am not sure how I
>> > can do that.
>> 
>> The variable current-prefix-arg has that information.
>
> Thanks a lot.  But did you mean last-prefix-arg instead?

No, but I had misread last-command for this-command. Sorry about that.
last-prefix-arg sounds like a good candidate from its docstring, but I
don't understand how it works:

(defun yf/foo (arg)
  (interactive "i")
  (message "Last: %s : %s\nThis: %s : %s"
           last-command last-prefix-arg 
           this-command current-prefix-arg))
(local-set-key (kbd "<f5>") #'yf/foo)

Hitting RET RET C-u <f5> in a buffer shows me:
Last: newline : (4)
This: yf/foo : (4)

I expected

Last: newline : nil
This: yf/foo : (4)

would someone have an explanation ?

-- 
Nico.

Re: Getting last-command with arguments

[Xue Fuqiao]

On Fri, Sep 13, 2013 at 9:58 PM, Nicolas Richard
<theonewiththeevillook@yahoo.fr> wrote:
> last-prefix-arg sounds like a good candidate from its docstring, but I
> don't understand how it works:
>
> (defun yf/foo (arg)
>   (interactive "i")
>   (message "Last: %s : %s\nThis: %s : %s"
>            last-command last-prefix-arg
>            this-command current-prefix-arg))
> (local-set-key (kbd "<f5>") #'yf/foo)
>
> Hitting RET RET C-u <f5> in a buffer shows me:
> Last: newline : (4)
> This: yf/foo : (4)
>
> I expected
>
> Last: newline : nil
> This: yf/foo : (4)

I just tried it with r114269 and it worked as you expected.

-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

Re: Getting last-command with arguments

[Nicolas Richard]

Xue Fuqiao <xfq.free@gmail.com> writes:
> On Fri, Sep 13, 2013 at 9:58 PM, Nicolas Richard
>> Hitting RET RET C-u <f5> in a buffer shows me:
>> Last: newline : (4)
>> This: yf/foo : (4)
>>
>> I expected
>>
>> Last: newline : nil
>> This: yf/foo : (4)
>
> I just tried it with r114269 and it worked as you expected.

Thanks for your input. I tried from the tip of the emacs-24 branch and
the result is the unexpected one, but trying from trunk indeed gives the
expected result.

-- 
Nicolas.